Virtual Machines tab on NAD/UDN/CUDN detail pages

[Parthivk100]

Virtual Machines tab on NAD/UDN/CUDN detail pages

Summary by CodeRabbit

• New Features
  • Added a dedicated NetworkAttachmentDefinition details page with summary information, YAML editing, and tabbed navigation.
  • Added NetworkAttachmentDefinition Virtual Machines view with search, sorting, pagination, status/interface details, and VM counts.
  • Added workflows to add or remove Virtual Machines from both NADs and UDNs (including bulk add and confirmations).
• Refactor
  • Consolidated NetworkAttachmentDefinition and UDN details into the unified resource-details page experience.
• Style
  • Made confirmation modals support configurable submit button styling.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Parthivk100
Once this PR has been reviewed and has the lgtm label, please assign metalice for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Caution

Review failed

An error occurred during the review process. Please try again later.

Walkthrough

Adds NAD and UDN resource detail pages with metadata, YAML, and associated VirtualMachine tabs. It also introduces NAD-aware Multus patch helpers for attaching, reconnecting, hot-unplugging, and removing VMs, plus searchable DataView management and localized UI strings.

Changes

Network resource detail pages

Layer / File(s)	Summary
Resource detail pages and navigation src/views/nads/manifest.ts, src/views/nads/details/..., src/views/udns/manifest.ts, src/views/udns/details/..., src/views/nads/actions/NADActions.tsx	Registers NAD and UDN resource detail page extensions, watches resources, renders localized metadata/YAML/VM tabs, and wires resource actions.

VM association management

Layer / File(s)	Summary
VM discovery and DataView management src/views/nads/details/hooks/..., src/views/nads/details/tabs/virtualMachines/..., src/views/udns/details/hooks/..., src/views/udns/details/tabs/virtualMachines/...	Discovers associated and available VMs, renders filtering/sorting/pagination states, supports bulk selection and attachment, and provides confirmation actions for removal.

NAD-aware VM network operations

Layer / File(s)	Summary
NAD-aware VM network patches src/utils/resources/vm/utils.ts	Adds NAD/UDN matching, Multus naming, interface creation, indexed removal, orphan cleanup, hot-unplug, reconnection, and append patch helpers.

Shared UI and localization

Layer / File(s)	Summary
Shared confirmation UI and supporting resources src/utils/components/ConfirmModal/ConfirmModal.tsx, package.json, locales/*/plugin__networking-console-plugin.json	Adds configurable confirmation button variants, removes the modal top-position override, adds the PatternFly DataView development dependency, and adds VM networking UI strings.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant NADDetailsPage
  participant useK8sWatchResource
  participant useNADVirtualMachines
  participant HorizontalNav
  NADDetailsPage->>useK8sWatchResource: watch the NAD resource
  NADDetailsPage->>useNADVirtualMachines: derive related VMs and count
  NADDetailsPage->>HorizontalNav: render details, YAML, and VM tabs

Loading

sequenceDiagram
  participant AddVirtualMachinesModal
  participant addVMToNAD
  participant VirtualMachineAPI
  participant removeVMFromNAD
  AddVirtualMachinesModal->>addVMToNAD: submit selected VMs
  addVMToNAD->>VirtualMachineAPI: apply NAD-aware network patches
  removeVMFromNAD->>VirtualMachineAPI: remove or mark the VM connection absent

Loading

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@Parthivk100: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.