Skip to content

MGMT-24454: update CAPOA CI build root to Go 1.26.2 #80022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shay23bra wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

MGMT-24454: update CAPOA CI build root to Go 1.26.2 #80022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ build_root:
ln -sf /usr/bin/pip3.12 /usr/bin/pip && \
pip install ansible ansible-lint && \
curl -Ls https://github.com/mikefarah/yq/releases/latest/download/yq_linux_amd64 | install -m 755 /dev/stdin /usr/local/bin/yq && \
wget -q https://go.dev/dl/go1.25.5.linux-amd64.tar.gz && \
wget -q https://go.dev/dl/go1.26.2.linux-amd64.tar.gz && \
rm -rf /usr/local/go && \
tar -C /usr/local -xzf go1.25.5.linux-amd64.tar.gz && \
rm -f go1.25.5.linux-amd64.tar.gz && \
tar -C /usr/local -xzf go1.26.2.linux-amd64.tar.gz && \
rm -f go1.26.2.linux-amd64.tar.gz && \
Comment on lines +22 to +25
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify Go 1.26.2 tarball exists and check upstream go.mod Go version requirement

echo "=== Checking Go 1.26.2 availability ==="
curl -I -s -o /dev/null -w "%{http_code}" https://go.dev/dl/go1.26.2.linux-amd64.tar.gz | grep -q "^200$" && \
  echo "✓ Go 1.26.2 tarball is available" || \
  echo "✗ Go 1.26.2 tarball not found (HTTP status not 200)"

echo ""
echo "=== Checking upstream go.mod Go version ==="
if [[ -f go.mod ]]; then
  echo "Found go.mod in openshift/release repo (not the upstream repo being tested)"
fi

# Check the upstream repo's go.mod by cloning it temporarily
TEMP_DIR=$(mktemp -d)
cd "$TEMP_DIR"
git clone --depth 1 https://github.com/openshift-assisted/cluster-api-provider-openshift-assisted.git
cd cluster-api-provider-openshift-assisted

if [[ -f go.mod ]]; then
  GO_VERSION=$(rg -n '^go\s+' go.mod | head -1)
  echo "Upstream go.mod declares: $GO_VERSION"
  
  if echo "$GO_VERSION" | grep -q "1.26"; then
    echo "✓ Upstream requires Go 1.26"
  else
    echo "✗ Upstream does not require Go 1.26"
  fi
else
  echo "✗ No go.mod found in upstream repo"
fi

cd /
rm -rf "$TEMP_DIR"

Repository: openshift/release

Length of output: 410

🌐 Web query:

What is the latest Go 1.26 version available as of June 2026?

💡 Result:

As of June 3, 2026, the latest Go 1.26 version available is go1.26.4, which was released on June 2, 2026 [1]. This version includes security fixes for the crypto/x509, mime, and net/textproto packages, along with various bug fixes [1].

Citations:

Go toolchain bump to 1.26.2 is likely broken (missing tarball) and may not match upstream requirements

  • This config downloads go1.26.2.linux-amd64.tar.gz (lines 22-25), but go.dev does not serve that tarball (non-200 response), so the build environment may fail.
  • The upstream cluster-api-provider-openshift-assisted go.mod currently declares go 1.25.0, so the Go 1.26 update should be aligned with upstream (and the referenced upstream PR #717).

Consider switching to an actually released Go 1.26.x tarball (e.g., go1.26.4) or aligning the toolchain version with the upstream go.mod.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift-assisted/cluster-api-provider-openshift-assisted/openshift-assisted-cluster-api-provider-openshift-assisted-master.yaml`
around lines 22 - 25, The Dockerfile snippet is attempting to fetch go1.26.2
which isn't available; update the tarball URL to a valid released Go binary
(e.g., change go1.26.2.linux-amd64.tar.gz to a released patch like
go1.26.4.linux-amd64.tar.gz) or instead align the toolchain with the module's
declared version by reverting to Go 1.25.x to match the repository go.mod;
ensure the wget target and all subsequent references (the wget line and the tar
-C /usr/local -xzf invocation) use the same valid tarball name so the download
and extraction succeed.

mkdir /tmp/kubectl && \
curl -sSLO "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl" && \
install -o root -g root -m 0755 kubectl /usr/local/bin/kubectl && \
Expand Down