Skip to content

ci-operator: add bundle name for ingress-node-firewall#81250

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smulje:add-ingress-node-firewall-bundle-name
Jul 10, 2026
Merged

ci-operator: add bundle name for ingress-node-firewall#81250
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
smulje:add-ingress-node-firewall-bundle-name

Conversation

@smulje

@smulje smulje commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

Add as: ingress-node-firewall-bundle to the operator bundle configuration for ingress-node-firewall to fix cluster-bot compatibility.

Why

Without a named bundle, cluster-bot commands fail with:

build openshift/ingress-node-firewall#721
Cluster Bot  :
each use of the image_or_version_or_prs parameter must specify a valid OpenShift version.
[openshift/ingress-node-firewall#721] has no valid OpenShift version

build 4.22,openshift/ingress-node-firewall#721
Cluster Bot  :
the requested job cannot be started: unable to locate test using unnamed bundle

This prevents developers from using cluster-bot to test PRs:

  • launch openshift/ingress-node-firewall#<PR> aws
  • build openshift/ingress-node-firewall#<PR>

What

  • Add as: ingress-node-firewall-bundle to the bundle definition in openshift-ingress-node-firewall-master.yaml
  • Follows the naming convention used by other operators (cluster-logging-operator-bundle, local-storage-operator-bundle)

Summary by CodeRabbit

Updated OpenShift CI operator bundle configuration for ingress-node-firewall to add an explicit bundle identifier (as: ingress-node-firewall-bundle, with dockerfile_path: bundle.Dockerfile) in ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-master.yaml and the corresponding openshift-ingress-node-firewall-release-*.yaml files (4.12–5.1). This gives cluster-bot a stable way to resolve the bundle during PR launch/build workflows that previously failed with an “unnamed bundle” test lookup error.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2026
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Adds as: ingress-node-firewall-bundle to the ingress-node-firewall operator.bundles entries in the master and release CI operator configs.

Changes

Ingress-node-firewall bundle alias

Layer / File(s) Summary
Bundle alias updates
ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-master.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.12.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.13.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.14.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.15.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.16.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.17.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.18.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.19.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.20.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.21.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.22.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-4.23.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-5.0.yaml, ci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-5.1.yaml
The operator.bundles entries now include as: ingress-node-firewall-bundle alongside dockerfile_path: bundle.Dockerfile in each updated configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes CI/operator YAML and presubmit config; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed The PR only changes CI/operator YAML and Prow job configs; no Ginkgo test code was added or modified, so the test-quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo tests were added or modified; the PR only updates ci-operator YAML/job wiring for the bundle alias.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only changes ci-operator/prow YAML bundle naming; no new Ginkgo e2e tests or node-topology logic were added, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator bundle aliases were added; no deployment manifests, controllers, affinity, node selectors, replicas, or PDBs changed.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML configs changed; no main/suite setup or stdout-writing binary code was modified, so the OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests were added; the PR only changes ci-operator/prow YAML for bundle naming and job targeting.
No-Weak-Crypto ✅ Passed PR only updates CI YAML bundle aliases/job names; no crypto primitives, custom crypto, or secret/token comparisons were introduced.
Container-Privileges ✅ Passed Changed files only add operator.bundle aliases; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed Changed files are only CI operator YAMLs; no logging, secrets, tokens, PII, or customer-data exposure appears in the diff.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding a named bundle for ingress-node-firewall in ci-operator config.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@smulje smulje marked this pull request as ready for review June 30, 2026 08:08
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2026
@openshift-ci openshift-ci Bot requested review from abhat and danwinship June 30, 2026 08:14
@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch 2 times, most recently from 70f890d to 01e7240 Compare June 30, 2026 10:25
@danwinship

Copy link
Copy Markdown
Contributor

I have no idea if this is right... it would be good to get someone who understands this stuff to confirm. Or if you could point to some documentation that says that this fix is needed?

@smulje

smulje commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

According to the ci-tools Bundle type definition in ci-tools Bundle type definition, each bundle has three identifying fields:

  • as: — explicit bundle name
  • context_dir: — relative directory for the bundle build
  • dockerfile_path: — path to the Dockerfile relative to context_dir

When as: is not provided, a name is auto-generated — typically derived from context_dir. However, when both as: and context_dir: are absent (i.e. the bundle Dockerfile is at the repository root), the auto-generated name is effectively empty. This causes cluster-bot to fail with "unable to locate test using unnamed bundle".

Additionally, the IsBundleImage() function in the same file explicitly checks bundle.As != "" when matching bundle images — meaning bundles without an explicit name cannot be resolved through this path.

For ingress-node-firewall, since bundle.Dockerfile is at the repository root (not in a subdirectory), we use as: ingress-node-firewall-bundle to provide an explicit identifier. This follows the same pattern as metallb-operator (as: operatorbundle) and local-storage-operator (as: local-storage-operator-bundle).

Empirical verification: build 4.22,openshift/cluster-nfd-operator#464 (has context_dir) works, while build 4.22,openshift/ingress-node-firewall#721 (has neither as nor context_dir) fails with the unnamed bundle error.

I have also raised thread with art team to confirm findings.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 01e7240 to 9455d72 Compare July 6, 2026 11:13
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: error unmarshalling /var/tmp/gitrepo3728993721/ci-operator/jobs/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-5.1-presubmits.yaml: error converting YAML to JSON: yaml: line 10: did not find expected comment or line break
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 120454c to 690f022 Compare July 6, 2026 11:23
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: error unmarshalling /var/tmp/gitrepo91318068/ci-operator/jobs/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-5.1-presubmits.yaml: error converting YAML to JSON: yaml: line 10: did not find expected comment or line break
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 690f022 to cde82ba Compare July 6, 2026 11:25
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load Prow configuration from release repo: error unmarshalling /var/tmp/gitrepo46253913/ci-operator/jobs/openshift/ingress-node-firewall/openshift-ingress-node-firewall-release-5.1-presubmits.yaml: error converting YAML to JSON: yaml: line 10: did not find expected comment or line break
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch 2 times, most recently from 587c7b7 to 01e7240 Compare July 6, 2026 12:30
@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 4f50a93217647645e31f2758fff0226351f009b5 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 01e7240 to c1c8b8d Compare July 6, 2026 12:48
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2026
@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from c1c8b8d to 108a2d6 Compare July 6, 2026 13:07
@hoxhaeris

Copy link
Copy Markdown
Contributor

/lgtm
cluster-bot identifies the bundle by name when processing a build command. Without either the as or context_dir field, ci-operator cannot resolve which bundle to use, resulting in the unable to locate test using unnamed bundle error. This PR fixes that by ensuring the bundle can be identified correctly, LGTM.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2026
@danwinship

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2026
@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 108a2d6 to 78b9c12 Compare July 9, 2026 13:13
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto 190f70d547a4fef800feb46ca39681c2ea48b0e4 due to conflicts
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 78b9c12 to 201476c Compare July 9, 2026 13:38
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

  Add 'as: ingress-node-firewall-bundle' to the operator bundle configuration
  to fix 'unable to locate test using unnamed bundle' error when using
  cluster-bot commands.

  This enables cluster-bot workflows:
  - launch openshift/ingress-node-firewall#<PR> <platform>
  - build openshift/ingress-node-firewall#<PR>

  Follows the pattern used by other operators like cluster-logging-operator
  and local-storage-operator.

Signed-off-by: Swati <smulje@redhat.com>
@smulje smulje force-pushed the add-ingress-node-firewall-bundle-name branch from 201476c to 9c43d1d Compare July 9, 2026 14:18
@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 9, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@smulje: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ingress-node-firewall-master-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.12-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.13-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.14-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.15-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.16-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.17-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.18-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.19-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.20-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.21-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.22-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.23-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-5.0-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-5.1-ci-index-ingress-node-firewall-bundle openshift/ingress-node-firewall presubmit Presubmit changed
pull-ci-openshift-ingress-node-firewall-release-4.17-images openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.17-ingress-node-firewall-e2e-metal-ipi openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.17-lint openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.17-test-fmt openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.17-unit-test openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.20-images openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.20-ingress-node-firewall-e2e-metal-ipi openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.20-lint openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.20-test-fmt openshift/ingress-node-firewall presubmit Ci-operator config changed
pull-ci-openshift-ingress-node-firewall-release-4.20-unit-test openshift/ingress-node-firewall presubmit Ci-operator config changed

A total of 98 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@smulje

smulje commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/test stackrox-stackrox-stackrox-stackrox-check

@smulje

smulje commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@smulje

smulje commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@smulje: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 10, 2026
@smulje

smulje commented Jul 10, 2026

Copy link
Copy Markdown
Member Author

@hoxhaeris Rebased to resolve merge conflict, no code changes. could you add /lgtm again? Thanks!!

@hoxhaeris

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2026
@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, hoxhaeris, smulje

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@smulje: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9ce4dac into openshift:main Jul 10, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants