ci-operator: add bundle name for ingress-node-firewall#81250
Conversation
|
Skipping CI for Draft Pull Request. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds ChangesIngress-node-firewall bundle alias
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
70f890d to
01e7240
Compare
|
I have no idea if this is right... it would be good to get someone who understands this stuff to confirm. Or if you could point to some documentation that says that this fix is needed? |
|
According to the ci-tools Bundle type definition in ci-tools Bundle type definition, each bundle has three identifying fields:
When as: is not provided, a name is auto-generated — typically derived from context_dir. However, when both as: and context_dir: are absent (i.e. the bundle Dockerfile is at the repository root), the auto-generated name is effectively empty. This causes cluster-bot to fail with "unable to locate test using unnamed bundle". Additionally, the IsBundleImage() function in the same file explicitly checks bundle.As != "" when matching bundle images — meaning bundles without an explicit name cannot be resolved through this path. For ingress-node-firewall, since bundle.Dockerfile is at the repository root (not in a subdirectory), we use as: ingress-node-firewall-bundle to provide an explicit identifier. This follows the same pattern as metallb-operator (as: operatorbundle) and local-storage-operator (as: local-storage-operator-bundle). Empirical verification: build 4.22,openshift/cluster-nfd-operator#464 (has context_dir) works, while build 4.22,openshift/ingress-node-firewall#721 (has neither as nor context_dir) fails with the unnamed bundle error. I have also raised thread with art team to confirm findings. |
01e7240 to
9455d72
Compare
|
@smulje, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
120454c to
690f022
Compare
|
@smulje, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
690f022 to
cde82ba
Compare
|
@smulje, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
587c7b7 to
01e7240
Compare
|
@smulje, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
01e7240 to
c1c8b8d
Compare
c1c8b8d to
108a2d6
Compare
|
/lgtm |
|
/approve |
108a2d6 to
78b9c12
Compare
|
@smulje, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
78b9c12 to
201476c
Compare
|
@smulje: |
Add 'as: ingress-node-firewall-bundle' to the operator bundle configuration to fix 'unable to locate test using unnamed bundle' error when using cluster-bot commands. This enables cluster-bot workflows: - launch openshift/ingress-node-firewall#<PR> <platform> - build openshift/ingress-node-firewall#<PR> Follows the pattern used by other operators like cluster-logging-operator and local-storage-operator. Signed-off-by: Swati <smulje@redhat.com>
201476c to
9c43d1d
Compare
|
[REHEARSALNOTIFIER]
A total of 98 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/test stackrox-stackrox-stackrox-stackrox-check |
|
/pj-rehearse auto-ack |
|
@smulje: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse ack |
|
@smulje: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hoxhaeris Rebased to resolve merge conflict, no code changes. could you add /lgtm again? Thanks!! |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, hoxhaeris, smulje The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@smulje: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Add
as: ingress-node-firewall-bundleto the operator bundle configuration for ingress-node-firewall to fix cluster-bot compatibility.Why
Without a named bundle, cluster-bot commands fail with:
This prevents developers from using cluster-bot to test PRs:
launch openshift/ingress-node-firewall#<PR> awsbuild openshift/ingress-node-firewall#<PR>What
as: ingress-node-firewall-bundleto the bundle definition inopenshift-ingress-node-firewall-master.yamlSummary by CodeRabbit
Updated OpenShift CI operator bundle configuration for
ingress-node-firewallto add an explicit bundle identifier (as: ingress-node-firewall-bundle, withdockerfile_path: bundle.Dockerfile) inci-operator/config/openshift/ingress-node-firewall/openshift-ingress-node-firewall-master.yamland the correspondingopenshift-ingress-node-firewall-release-*.yamlfiles (4.12–5.1). This gives cluster-bot a stable way to resolve the bundle during PRlaunch/buildworkflows that previously failed with an “unnamed bundle” test lookup error.