Fix wlc/index.xml URN slugs for Samuel/Kings/Chronicles - #16
Merged
Conversation
Regenerated with the transform_index.xslt fix in opensiddur-ai (companion PR): the six paired-book transcludes previously pointed at urn:x-opensiddur:text:bible:1_samuel-style URNs (ordinal first) that no file in this project publishes -- every book file uses the ordinal-last convention instead (samuel_1, kings_2, chronicles_1). Regenerating with the corrected generator swaps only those six @target values; every other transclude in the file, and the rest of the project, is unaffected. Confirmed against a full reference-database rebuild: opensiddur.exporter.validate_urn_references now exits 0 for wlc (and every other project), where it previously reported these six as unresolvable. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates
project/wlc/index.xmlwith thetransform_index.xsltfix inopensiddur/opensiddur-ai#102: the six paired-book transcludes previously pointed at
urn:x-opensiddur:text:bible:1_samuel-style URNs (ordinal first) that no file in thisproject publishes — every book file uses the ordinal-last convention instead (
samuel_1,kings_2,chronicles_1). Regenerating with the corrected generator swaps only those six@targetvalues; nothing else in the file changed.Depends on opensiddur/opensiddur-ai#102 merging first (that's where the actual fix and
its tests live — this is the regenerated output).
Found while verifying opensiddur-ai#94's new required CI check against real data.
Test plan
Confirmed against a full reference-database rebuild from this branch's project files:
opensiddur.exporter.validate_urn_references wlcnow exits0(previously reported thesesix as unresolvable).
opensiddur.exporter.validate_schema --project wlc— all 40 files still schema-valid.opensiddur.exporter.validate_versification— unaffected (OK, same 3 known-unresolvedjps1917 chapters as before; this fix only touches transclude targets, not verse URNs).
feinstein_haggadah_translation_2009,heidenheim_haggadah_1822,humash,jps1917,miqra_al_pi_hamasorah,original-example,translation-example)also validates clean against the rebuilt reference database.
This PR will also be the first real exercise of the new required check from #15/opensiddur-ai#94.
🤖 Generated with Claude Code