Skip to content

chore(sdk): drop dead TDFConfig fields and deprecate the TDFFormat enum #3947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmihalcik-virtru wants to merge 1 commit into
base: dspx-2604-17-createtdf-delegates
Choose a base branch
from
+6 −5
Open

chore(sdk): drop dead TDFConfig fields and deprecate the TDFFormat enum #3947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/tdf.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const (
kAssertionSignature = "assertionSig"
kAssertionHash = "assertionHash"
hexSemverThreshold = "4.3.0"
readActionName = "read"
)

// Loads and reads ZTDF files
Expand Down
10 changes: 6 additions & 4 deletions sdk/tdf_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,16 @@ const (
inputSizeUnknown = -1
)

// TDFFormat once selected a manifest serialization. Only JSON was ever
// implemented, and nothing reads this.
//
// Deprecated: unused; the manifest is always JSON.
type TDFFormat = int

const (
// Deprecated: unused; the manifest is always JSON.
JSONFormat = iota
// Deprecated: never implemented.
XMLFormat
)

Expand Down Expand Up @@ -68,8 +74,6 @@ type TDFConfig struct {
autoconfigure bool
defaultSegmentSize int64
inputSize int64
enableEncryption bool
tdfFormat TDFFormat
metaData string
mimeType string
integrityAlgorithm IntegrityAlgorithm
Expand All @@ -91,8 +95,6 @@ func newTDFConfig(opt ...TDFOption) (*TDFConfig, error) {
autoconfigure: true,
defaultSegmentSize: defaultSegmentSize,
inputSize: inputSizeUnknown,
enableEncryption: true,
tdfFormat: JSONFormat,
integrityAlgorithm: HS256,
segmentIntegrityAlgorithm: GMAC,
addDefaultAssertion: false,
Expand Down
Loading