Skip to content

fix: preserve AUIPC AOT immediates#2855

Open
Kuhai9801 wants to merge 3 commits into
openvm-org:mainfrom
Kuhai9801:rv32im-auipc-immediate
Open

fix: preserve AUIPC AOT immediates#2855
Kuhai9801 wants to merge 3 commits into
openvm-org:mainfrom
Kuhai9801:rv32im-auipc-immediate

Conversation

@Kuhai9801

@Kuhai9801 Kuhai9801 commented Jun 7, 2026

Copy link
Copy Markdown

Fixes #2851.

Summary

RV32IM AUIPC AOT now uses the raw 24-bit transpiled immediate when computing pc + (imm << 8), instead of narrowing the immediate through i16.

Testing

  • OPENVM_FAST_TEST=1 OPENVM_SKIP_DEBUG=1 cargo test -p openvm-rv32im-circuit --features aot aot_uses_full_24_bit_auipc_immediate
  • cargo +nightly fmt --all -- --check
  • cargo clippy -p openvm-rv32im-circuit --features aot --all-targets -- -D warnings

@Kuhai9801 Kuhai9801 marked this pull request as ready for review June 8, 2026 13:45

@GunaDD GunaDD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you that the issue is valid and the fix is correct. Thank you for this! Could you undo the change in the isa.mdx file? Other than that, LGTM.

Comment thread docs/vocs/docs/pages/specs/openvm/isa.mdx Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RV32IM AUIPC AOT truncates transpiled immediates

2 participants