feat: add test sweeps for internal prover & root prover#2889
Open
Aalanli wants to merge 7 commits into
Open
Conversation
Author
|
Currently the root sweep fails with this config: with error message |
Author
|
And internal sweep fails with this config: with this error: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author
|
Hi @stephenh-axiom-xyz , can you take a look? |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
stephenh-axiom-xyz
left a comment
Contributor
There was a problem hiding this comment.
Rn params are only modified in fib_sdk, every instance of *_params_with_100_bits_security should be replaced. Probably best to make a helper for this
47ed80d to
638b3d1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 6 commits
June 19, 2026 18:34
feat: add root sweep as well fix: make script based testing fix: patch other tests with config override
This comment has been minimized.
This comment has been minimized.
Note: cells_used metrics omitted because CUDA tracegen does not expose unpadded trace heights. Commit: 0bdc24f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: INT-8260
The workflow I have is:
Another approach is to modify stark-backend to export some kind of get_sweeps function. Anyways if we don't want to deserialize we need to modify stark backend as making a
SystemParamneeds some non-public constants and functions fromsoundness.rs.sweep parameters
Sweeping over internal config:
log_blowups: 1..=7
k_whirs: (1..=7).step_by(2)
l_skips: (1..=18).steup_by(4)
n_stack = 19 - l_skips
w_stack = 512
Sweeping over root config:
log_blowups: [2, 3, 4, 5, 6]
k_whirs: (1..=7).step_by(2)
l_skips: vec![2, 4, 8, 14, 18]
n_stack = 20 - l_skips
w_stack = 18