Skip to content

chore(deps): bump eslint-plugin-sonarjs from 4.1.0 to 4.2.0 #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescmartinez merged 2 commits into from
Jul 17, 2026
Merged

chore(deps): bump eslint-plugin-sonarjs from 4.1.0 to 4.2.0 #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90ceff6
chore(deps): bump eslint-plugin-sonarjs from 4.1.0 to 4.2.0
dependabot[bot] Jul 17, 2026
95d871f
fix: sonarjs 4.2.0
jamescmartinez Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
91 changes: 45 additions & 46 deletions apps/dashboard/src/utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,53 +17,52 @@ describe("computeDuration", () => {
expect(result).toBe("-");
});

it("returns '< 1ms' for negative duration (clock skew)", () => {
const startedAt = new Date("2024-01-01T00:00:01.000Z");
const finishedAt = new Date("2024-01-01T00:00:00.000Z");
it.each<[string, Date, Date, string]>([
[
"returns '< 1ms' for negative duration (clock skew)",
new Date("2024-01-01T00:00:01.000Z"),
new Date("2024-01-01T00:00:00.000Z"),
"< 1ms",
],
[
"returns milliseconds for durations under 1 second",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:00:00.500Z"),
"500ms",
],
[
"returns seconds with one decimal for durations under 1 minute",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:00:05.500Z"),
"5.5s",
],
[
"returns minutes only when seconds are 0",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:02:00.000Z"),
"2m",
],
[
"returns minutes and seconds for durations over 1 minute",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:02:30.000Z"),
"2m 30s",
],
[
"rounds seconds when formatting minutes and seconds",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:02:30.600Z"),
"2m 31s",
],
[
"handles 0ms duration",
new Date("2024-01-01T00:00:00.000Z"),
new Date("2024-01-01T00:00:00.000Z"),
"0ms",
],
])("%s", (_name, startedAt, finishedAt, expected) => {
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("< 1ms");
});

it("returns milliseconds for durations under 1 second", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:00:00.500Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("500ms");
});

it("returns seconds with one decimal for durations under 1 minute", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:00:05.500Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("5.5s");
});

it("returns minutes only when seconds are 0", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:02:00.000Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("2m");
});

it("returns minutes and seconds for durations over 1 minute", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:02:30.000Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("2m 30s");
});

it("rounds seconds when formatting minutes and seconds", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:02:30.600Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("2m 31s");
});

it("handles 0ms duration", () => {
const startedAt = new Date("2024-01-01T00:00:00.000Z");
const finishedAt = new Date("2024-01-01T00:00:00.000Z");
const result = computeDuration(startedAt, finishedAt);
expect(result).toBe("0ms");
expect(result).toBe(expected);
});
});

Expand Down
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"eslint-plugin-functional": "^10.0.0",
"eslint-plugin-import": "^2.32.0",
"eslint-plugin-jsdoc": "^63.0.10",
"eslint-plugin-sonarjs": "^4.1.0",
"eslint-plugin-sonarjs": "^4.2.0",
"eslint-plugin-unicorn": "^65.0.1",
"husky": "^9.1.7",
"jscpd": "^5.0.12",
Expand Down
30 changes: 7 additions & 23 deletions packages/openworkflow/core/cursor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,34 +77,18 @@ describe("encodeCursor", () => {
expect(parsed["extra"]).toBeUndefined();
});

test("handles empty id", () => {
test.each<[string, string]>([
["empty id", ""],
["ids with special characters", 'weird/"\\id\n\t'],
["unicode ids", "🚀-café-漢字"],
])("handles %s", (_name, id) => {
const cursor: Cursor = {
createdAt: new Date("2026-01-15T12:34:56.789Z"),
id: "",
id,
};
const encoded = encodeCursor(cursor);
const decoded = decodeCursor(encoded);
expect(decoded.id).toBe("");
});

test("handles ids with special characters", () => {
const cursor: Cursor = {
createdAt: new Date("2026-01-15T12:34:56.789Z"),
id: 'weird/"\\id\n\t',
};
const encoded = encodeCursor(cursor);
const decoded = decodeCursor(encoded);
expect(decoded.id).toBe('weird/"\\id\n\t');
});

test("handles unicode ids", () => {
const cursor: Cursor = {
createdAt: new Date("2026-01-15T12:34:56.789Z"),
id: "🚀-café-漢字",
};
const encoded = encodeCursor(cursor);
const decoded = decodeCursor(encoded);
expect(decoded.id).toBe("🚀-café-漢字");
expect(decoded.id).toBe(id);
});
});

Expand Down
1 change: 0 additions & 1 deletion packages/openworkflow/core/standard-schema.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,5 @@ export declare namespace StandardSchemaV1 {
>["output"];

// needed for granular visibility control of the Standard Schema namespace.
// eslint-disable-next-line unicorn/require-module-specifiers
export {};
}
Loading