Add Gate 1 AST static vacuity analysis linter for UI test suites. - #3277
Open
copybara-service[bot] wants to merge 1 commit into
Open
Add Gate 1 AST static vacuity analysis linter for UI test suites.#3277copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_971169428
branch
from
September 1, 2026 10:18
c2bbd7a to
0eafb26
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_971169428
branch
3 times, most recently
from
September 3, 2026 06:01
cc98870 to
28e34b0
Compare
copybara-service
Bot
changed the title
Key Capabilities Introduced in this CL:
1. Gate 1 Static AST Vacuity Analysis Linter (tests/ui/lint_vacuity.py):
- Recursively parses test ASTs to detect anti-patterns including
conditional assertions (if blocks guarding assertions), vacuous tests with
0 assertions or expects, empty or whitespace locators, and keyword
selector arguments.
- Respects hermetic runfiles and sandbox directory hierarchies, enforcing
non-zero test file discovery.
2. Presubmit & CI Linter Targets:
- Integrates lint_vacuity_test in tests/ui/BUILD and kokoro_build_testing.sh.
- Ensures all UI test suites maintain 0 vacuity violations.
PiperOrigin-RevId: 971169428
copybara-service
Bot
force-pushed
the
test_971169428
branch
from
September 3, 2026 06:37
28e34b0 to
0d88118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Gate 1 AST static vacuity analysis linter for UI test suites.
Key Capabilities Introduced in this CL:
conditional assertions (if blocks guarding assertions), vacuous tests with
0 assertions or expects, empty or whitespace locators, and keyword
selector arguments.
non-zero test file discovery.