Skip to content

Pass through raw_trace_viewer arguments to the frontend by piping them natively from WASM via EventData maps. This bypasses the maybeFetchEventArgs fallback for raw trace viewer. Setup types in TS to handle natively populated args. #3349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Sep 8, 2026
Merged

Pass through raw_trace_viewer arguments to the frontend by piping them natively from WASM via EventData maps. This bypasses the maybeFetchEventArgs fallback for raw trace viewer. Setup types in TS to handle natively populated args. #3349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions frontend/app/components/trace_viewer_container/trace_viewer_container.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,7 @@ canvas.emscripten {
.detail-value {
color: var(--mat-sys-on-surface);
word-break: break-word;
white-space: pre-wrap;
}
}

Expand Down Expand Up @@ -579,8 +580,10 @@ canvas.emscripten {
border-radius: 24px;
font-size: 13px;
font-family: 'Google Sans Text', Roboto, sans-serif;
box-shadow: 0 4px 12px rgba(0, 0, 0, 0.1), 0 1px 3px rgba(0,0,0,0.08);
border: 1px solid var(--md-sys-color-outline-variant, rgba(0,0,0,0.05));
box-shadow:
0 4px 12px rgba(0, 0, 0, 0.1),
0 1px 3px rgba(0, 0, 0, 0.08);
border: 1px solid var(--md-sys-color-outline-variant, rgba(0, 0, 0, 0.05));
pointer-events: none;
z-index: 10;
white-space: nowrap;
Expand Down Expand Up @@ -614,8 +617,12 @@ canvas.emscripten {
}

@keyframes fadeIn {
0% { opacity: 0; }
100% { opacity: 1; }
0% {
opacity: 0;
}
100% {
opacity: 1;
}
}

.timeline-status-bar mat-icon {
Expand Down Expand Up @@ -646,5 +653,5 @@ canvas.emscripten {
font-weight: 600;
padding: 2px 6px;
line-height: 14px;
box-shadow: 0 1px 1px rgba(0,0,0,0.05);
box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05);
}
1 change: 1 addition & 0 deletions frontend/app/components/trace_viewer_container/trace_viewer_container.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ export declare interface EntrySelectedEventDetail {
uid?: string;
hloModuleName?: string;
hloOpName?: string;
args?: Record<string, string>;
}

// Type guard for the 'EntrySelected' custom event.
Expand Down
1 change: 1 addition & 0 deletions frontend/app/components/trace_viewer_v2/event_data.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ inline constexpr absl::string_view kEventSelectedUid = "uid";
inline constexpr absl::string_view kEventSelectedHloModuleName =
"hloModuleName";
inline constexpr absl::string_view kEventSelectedHloOpName = "hloOpName";
inline constexpr absl::string_view kEventSelectedArgs = "args";

// Constants for fetch data event.
inline constexpr absl::string_view kFetchData = "fetch_data";
Expand Down
7 changes: 7 additions & 0 deletions frontend/app/components/trace_viewer_v2/timeline/timeline.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1537,6 +1537,13 @@ EventData Timeline::CreateBaseEventData(int event_index, bool is_hover) const {
if (const auto it = args.find(kHloOp); it != args.end()) {
event_data.try_emplace(kEventSelectedHloOpName, it->second);
}

EventData js_args;
js_args.reserve(args.size());
for (const auto& [key, value] : args) {
js_args.try_emplace(key, value);
}
event_data.try_emplace(kEventSelectedArgs, std::move(js_args));
}
}
return event_data;
Expand Down
17 changes: 17 additions & 0 deletions frontend/app/components/trace_viewer_v2/timeline/timeline_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4667,6 +4667,23 @@ TEST_F(RealTimelineImGuiFixture, ClickEventWithArgsSelectsEvent) {
EXPECT_EQ(
std::any_cast<std::string>(event_detail.at(kEventSelectedHloOpName)),
"test_op");

ASSERT_TRUE(event_detail.contains(kEventSelectedArgs));
const auto* js_args =
std::any_cast<EventData>(&event_detail.find(kEventSelectedArgs)->second);
ASSERT_NE(js_args, nullptr);

const auto uid_it = js_args->find("uid");
ASSERT_NE(uid_it, js_args->end());
EXPECT_EQ(std::any_cast<std::string>(uid_it->second), "12345");

const auto hlo_module_it = js_args->find(kHloModule);
ASSERT_NE(hlo_module_it, js_args->end());
EXPECT_EQ(std::any_cast<std::string>(hlo_module_it->second), "test_module");

const auto hlo_op_it = js_args->find(kHloOp);
ASSERT_NE(hlo_op_it, js_args->end());
EXPECT_EQ(std::any_cast<std::string>(hlo_op_it->second), "test_op");
}

TEST_F(RealTimelineImGuiFixture, ClickEventSetsSelectionIndices) {
Expand Down