fix alert expressions using used_bytes instead of capacity_bytes - #136
Merged
Merged
Conversation
…acity bytes in denominator Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Neo4j Helm chart’s disk-usage alert PromQL to use kubelet_volume_stats_capacity_bytes as the denominator (instead of the previous used_bytes), and applies minor Go formatting changes in API tests and scheme registration.
Changes:
- Update Neo4j disk usage alert expressions to use
kubelet_volume_stats_capacity_bytesin the denominator. - Reformat
sc.New(...)invocation intypes_test.gofor readability/gofmt consistency. - Reformat
scheme.AddKnownTypes(...)calls inregister.gofor readability/gofmt consistency.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/neo4j-alerts/templates/alert.yaml | Updates PromQL expressions for Neo4j disk usage alerts to use capacity-based denominator. |
| apis/alerts/v1alpha1/types_test.go | Formatting-only change to multi-line constructor call. |
| apis/alerts/v1alpha1/register.go | Formatting-only change to multi-line AddKnownTypes calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
…s in denominator Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
The previous disk-alert fix (dd07db8) left one unmatched ')' in each DiskUsageHigh/DiskAlmostFull expression across 12 charts (used_bytes → capacity_bytes rewrite dropped an opening paren but kept its match), failing PrometheusRule validation at helm install. Removes the stray paren so expressions are byte-identical to the working mysql reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: Fazle Rabbi Sarker <fazlerabbi@appscode.com>
ArnobKumarSaha
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…acity bytes in denominator
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.