Remove CPU limits from otel collectors - #24
Merged
Merged
Conversation
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop `resources.limits.cpu` from the agent and gateway collectors to avoid CFS throttling during scrape and remote-write bursts. Memory limits stay because `memory_limiter` uses `limit_percentage` of the container memory limit.
The subchart defaults are also removed: `defaultCRConfig` is deep-merged under every collector in `templates/collector.yaml`, and `collectors.daemon` is coalesced under the parent values. Removing only the parent values would render 200m/250m CPU limits. `cpu: null` is rejected by the subchart values schema.
Also sets resources where none were set, without CPU limits:
Rendered:
```
x-gateway limits: {memory: 2Gi} requests: {cpu: 200m, memory: 768Mi}
x-agent limits: {memory: 2Gi} requests: {cpu: 200m, memory: 1Gi}
x-agent targetAllocator limits: {memory: 512Mi} requests: {cpu: 50m, memory: 128Mi}
operator manager limits: {memory: 512Mi} requests: {cpu: 50m, memory: 128Mi}
operator kube-rbac-proxy limits: {memory: 128Mi} requests: {cpu: 5m, memory: 32Mi}
```