[AI-FSSDK] [FSSDK-12670] Block ODP identify event for single identifier#513
Open
jaeopt wants to merge 1 commit into
Open
[AI-FSSDK] [FSSDK-12670] Block ODP identify event for single identifier#513jaeopt wants to merge 1 commit into
jaeopt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ODP identify event to only send when multiple identifiers exist. Previously, the SDK always sent an identify event when creating a user context, even with just a single
fs_user_id. This wastes network calls and pollutes ODP identity graphs with single-identifier records that provide no linking value.Changes
identify_usermethod signature across the identify chain to accept an identifiers dict instead of a single user_id stringOdpEventManager.identify_userto skip sending when fewer than 2 valid identifiers are presentJira Ticket
FSSDK-12670