Skip to content

Improve Test Trait Method Names - #45

Merged
ravage84 merged 15 commits into
cakephp-5.xfrom
44-improve-method-names
Sep 28, 2026
Merged

ravage84 merged 15 commits into
cakephp-5.xfrom
44-improve-method-names

Conversation

@Neluxx

@Neluxx Neluxx commented Sep 22, 2026

Copy link
Copy Markdown
Member

Closes #44

@Neluxx
Neluxx requested a review from ravage84 September 22, 2026 06:20
@Neluxx Neluxx self-assigned this Sep 22, 2026
@ravage84 ravage84 added this to the 3.0 milestone Sep 22, 2026
@ravage84

Copy link
Copy Markdown
Member

As discussed, the documentation adjustments are not done, yet.

@ravage84

Copy link
Copy Markdown
Member

Also as discussed, we should update the target branch once we agreed on a naming.

@ravage84 ravage84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍟

Comment thread tests/TestCase/Traits/DataValidationTestTraitTest.php Outdated
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
Comment thread src/Traits/DataValidationTestTrait.php Outdated
Comment thread CHANGELOG.md Outdated
@Neluxx
Neluxx requested a review from ravage84 September 23, 2026 06:47

@ravage84 ravage84 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with these changes we're ready got merge.

Comment thread docs/Migration.md Outdated
Comment thread docs/Migration.md Outdated
Comment thread src/Traits/DataValidationTestTrait.php
Comment thread CHANGELOG.md Outdated
@Neluxx
Neluxx requested a review from ravage84 September 28, 2026 10:47
Comment thread docs/Migration.md Outdated
@ravage84
ravage84 merged commit 1b58a79 into cakephp-5.x Sep 28, 2026
7 checks passed
@ravage84
ravage84 deleted the 44-improve-method-names branch September 28, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Test Trait Method Names

2 participants