Skip to content

adds batch export path - #8

Open
egbertn wants to merge 3 commits into
orionstudt:masterfrom
egbertn:master
Open

adds batch export path#8
egbertn wants to merge 3 commits into
orionstudt:masterfrom
egbertn:master

Conversation

@egbertn

@egbertn egbertn commented Dec 26, 2019

Copy link
Copy Markdown

a small addition to accounting/export

@orionstudt

Copy link
Copy Markdown
Owner

Hey man! Thanks for contributing.

I'm going to leave some notes and there's at least 1 issue I'm seeing right off the get go.

@orionstudt orionstudt left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made my comments.. thanks again for contributing!

Comment thread ModuleTypes/SubModuleChild.cs
Comment thread Modules/Finance/Finance.cs Outdated
Comment thread Modules/Finance/SubModules/AccountingBatches.cs
Comment thread Modules/Finance/SubModules/Export.cs Outdated
Comment thread Modules/Finance/SubModules/Export.cs
@egbertn

egbertn commented Dec 31, 2019

Copy link
Copy Markdown
Author

Think, so ok?

@orionstudt

Copy link
Copy Markdown
Owner

Hey man, thanks for the timely update! I'll take a look at it on my end after the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants