Skip to content

fix(usockets): snapshot loop before context unref in us_connecting_socket_free #29064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cirospaciari merged 2 commits into from
Apr 10, 2026
Merged

fix(usockets): snapshot loop before context unref in us_connecting_socket_free #29064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b45bd
fix(usockets): snapshot loop before context unref in us_connecting_so…
cirospaciari Apr 9, 2026
99f849f
Merge branch 'main' into claude/usockets-connecting-free-snapshot-loop
cirospaciari Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/bun-usockets/src/socket.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,11 @@ int us_socket_is_established(int ssl, struct us_socket_t *s) {
void us_connecting_socket_free(int ssl, struct us_connecting_socket_t *c) {
// we can't just free c immediately, as it may be enqueued in the dns_ready_head list
// instead, we move it to a close list and free it after the iteration
struct us_loop_t *loop = c->context->loop;
Copy link
Copy Markdown
Collaborator

@robobun robobun Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm

Copy link
Copy Markdown
Member Author

@cirospaciari cirospaciari Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good code right?

Copy link
Copy Markdown
Collaborator

@robobun robobun Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

us_internal_socket_context_unlink_connecting_socket(ssl, c->context, c);

c->next = c->context->loop->data.closed_connecting_head;
c->context->loop->data.closed_connecting_head = c;
c->next = loop->data.closed_connecting_head;
loop->data.closed_connecting_head = c;
}

void us_connecting_socket_close(int ssl, struct us_connecting_socket_t *c) {
Expand Down
Loading