Skip to content

fix(vfs): do not send an empty applyOtUpdate on save #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobertoReale wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vfs): do not send an empty applyOtUpdate on save #408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/core/remoteFileSystemProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -879,7 +879,12 @@ export class VirtualFileSystem extends vscode.Disposable {
})(),
};
this.isDirty = (update.op && update.op.length) ? true : false;
await this.socket.applyOtUpdate(doc._id, update);
// Skip the round-trip when the diff produced no operation (e.g. saving an
// unchanged document): the server has nothing to apply, answers with an error
// object and then force-disconnects the client 100ms later.
if (this.isDirty) {
await this.socket.applyOtUpdate(doc._id, update);
}
doc.localCache = mergeRes;
doc.remoteCache = mergeRes;
setTimeout(() => {
Expand Down