Save snapshots on another thread so they don't block the main one - #2255
Open
ada-tv wants to merge 1 commit into
Open
Save snapshots on another thread so they don't block the main one#2255ada-tv wants to merge 1 commit into
ada-tv wants to merge 1 commit into
Conversation
ada-tv
added
needs CR
vatral
approved these changes
May 5, 2026
HifiExperiments
added
CR approved
HifiExperiments
approved these changes
May 8, 2026
Member
|
One thing I noticed while testing this is that you can get Overte to crash now by spamming the screenshot button. I cannot get Overte to crash on the latest release by spamming the screenshot button; It will register only some of the button presses and just work off the screenshot requests one by one. By crash I mean Overte deadlocking after the error and throwing a SIGSEGV later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master
Hitches while compressing and saving the snapshot
snapshot-hitching-master.webm
This PR
Uses
QtConcurrent::runto save the snapshot on another thread, similar to how 360 snapshots are stitched into cubemaps/equirect maps usingQtConcurrent::runsnapshot-hitching-fix.webm