-
Notifications
You must be signed in to change notification settings - Fork 1
feat(editor): add word, page, and line navigation #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Issue 168: Word, page, buffer, and line navigation | ||
|
|
||
| ## Task and acceptance | ||
|
|
||
| Add M-f/M-b word movement and M-d/M-Backspace word kills through the existing kill ring. | ||
| Words are Unicode alphanumeric runs plus underscore, with combining marks kept in their containing grapheme. | ||
| Forward movement skips separators then reaches the end of a word; backward movement skips separators then reaches its beginning. | ||
| Word kills use those same boundaries and one undo edit, clearing the region after a successful cut. | ||
|
|
||
| Add M-</M-> for buffer start/end. | ||
| Add C-v/PageDown and M-v/PageUp for paging with two lines of overlap and at least one line of movement. | ||
| Store the last rendered viewport height in View, preserve the preferred display column, and keep point visible at edges and after resize. | ||
| Add goto-line with a positive one-based argument through M-x; clamp beyond EOF and reject zero, negative, overflow, and nonnumeric input without moving point. | ||
| All commands appear in the registry and end typing/yank-pop groups as deliberate actions. | ||
|
|
||
| ## Checks | ||
|
|
||
| Test Unicode words, punctuation, underscores, combining marks, emoji separators, empty buffers, EOF, and long lines. | ||
| Retain grapheme context in both directions and bound requested context bytes over growing regional-indicator fixtures. | ||
| Compare retained traversal against flat Unicode segmentation across rope chunk boundaries. | ||
| Test forward/backward kills with yank and undo, buffer endpoints, page overlap and edges, preferred columns, and all input mappings. | ||
| Test goto-line validation and named-command/key equivalence where applicable. | ||
| Run formatting, strict Clippy, the full suite, release build, independent review, and a real Unicode navigation/kill/yank/page/goto/save/quit session with shell restoration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.