Add source cell for disks, with side modal#3214
Open
charliepark wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "source" cell to each row in the Disks table, and to each Instance's "Storage" tab.
For each of those locations, it provides a side modal with more info on the source disk / snapshot / image.
In the Disk sidemodal, the source cell is not a link, to prevent stacking of side modals. This follows the pattern on #3158. I also added a badge to the side modal to indicate whether the source is from an image or a snapshot. We can remove that if we feel like it's too noisy. I left it off on the main view, since you can click into it to get more details.
Note that this image detail side modal has a slightly different layout than the existing image detail side modal, and we might want to just use the existing one. I do think the existing one has more of a pseudo-form feel to it, which might be more appropriate in its current location as a drill-down on the images index list, which looks like this:
Closes #2057