Skip to content

Automatically Load the hiffy_call result#664

Open
mkeeter wants to merge 1 commit into
mkeeter/generic-cellsfrom
mkeeter/hiffy-call-unpack
Open

Automatically Load the hiffy_call result#664
mkeeter wants to merge 1 commit into
mkeeter/generic-cellsfrom
mkeeter/hiffy-call-unpack

Conversation

@mkeeter
Copy link
Copy Markdown
Contributor

@mkeeter mkeeter commented May 12, 2026

(staged on #663)

This PR changes the return type from hiffy_call from Result<Result<Value, String>> to a Result<T: Load, HiffyCallError>. There are two changes here:

  • We automatically unpack into a T: Load (instead of returning a Value)
  • We collapse the nested outer / inner error types into an enum HiffyCallError, which represents both cases

This ends up being a bunch of churn, but is a significant cleanup overall.

@mkeeter mkeeter requested a review from labbott May 12, 2026 21:54
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 34d42b2 to 9899a0c Compare May 13, 2026 21:41
@mkeeter mkeeter force-pushed the mkeeter/generic-cells branch 2 times, most recently from 89d1b37 to b3a0238 Compare May 14, 2026 16:20
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 9899a0c to 76fc855 Compare May 14, 2026 16:20
@mkeeter mkeeter force-pushed the mkeeter/generic-cells branch from b3a0238 to 8b10ba0 Compare May 14, 2026 16:48
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 76fc855 to 7c9ee88 Compare May 14, 2026 16:48
@mkeeter mkeeter force-pushed the mkeeter/generic-cells branch from 8b10ba0 to 379e0b9 Compare May 14, 2026 19:08
@mkeeter mkeeter force-pushed the mkeeter/hiffy-call-unpack branch from 7c9ee88 to 1aaac5b Compare May 14, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant