Automatically Load the hiffy_call result#664
Open
mkeeter wants to merge 1 commit into
Open
Conversation
34d42b2 to
9899a0c
Compare
89d1b37 to
b3a0238
Compare
9899a0c to
76fc855
Compare
b3a0238 to
8b10ba0
Compare
76fc855 to
7c9ee88
Compare
8b10ba0 to
379e0b9
Compare
7c9ee88 to
1aaac5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(staged on #663)
This PR changes the return type from
hiffy_callfromResult<Result<Value, String>>to aResult<T: Load, HiffyCallError>. There are two changes here:T: Load(instead of returning aValue)enum HiffyCallError, which represents both casesThis ends up being a bunch of churn, but is a significant cleanup overall.