Fix pump statuses in pre-auth workflow documentation#2
Fix pump statuses in pre-auth workflow documentation#2
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Part 3 walkthrough to correct the documented pump-status transitions for the Pre-Auth workflow (Issue #1), aligning the flow diagram and examples with the intended Pre-Auth “locked idle” behavior.
Changes:
- Corrects Pre-Auth flow overview pump status sequence (locked idle → free → in-use → locked → locked).
- Updates Pre-Auth command handling snippets (
UNLOCKPUMP,LOCKPUMP,LOCKEDPUMP) to reflect corrected statuses. - Adjusts Pre-Auth full examples to match the corrected status transitions (including post-
CLEARand cancellation paths).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * PUMP 3 locked | ||
| * PUMP 3 free | ||
| ``` | ||
|
|
There was a problem hiding this comment.
This section says that after a successful UNLOCKPUMP the client should publish * PUMP 3 free, but Part 4’s “Pre-Auth Flow with TRANSACTIONINFO” example currently publishes * PUMP 1 locked immediately after UNLOCKPUMP (walkthrough/part-4.md:204-207). Please align the docs (either update Part 4’s example/status or add a clarifying note here about the correct status transition).
| > **Clarification:** Immediately after a successful `UNLOCKPUMP`, the pump should be published as `free` so the customer can begin fueling. If you see an example elsewhere in the walkthrough showing `locked` immediately after `UNLOCKPUMP`, treat that as outdated — `locked` is not the correct post-unlock status transition here. |
| Server: S2 CLEAR 3 e2f74ef5-f427-4ae6-bdd3-70a96709992f e2f74ef5-f427-4ae6-bdd3-70a96709992f pace | ||
| Client: S2 OK | ||
| Client: * PUMP 3 free | ||
| Client: * PUMP 3 locked |
There was a problem hiding this comment.
In the Pre-Auth full example, after CLEAR the pump status is updated to locked, but Step 6 describes CLEAR as freeing the pump and shows * PUMP 3 free on success (walkthrough/part-3.md:249-274). Please reconcile these two descriptions (e.g., document that Post-Pay returns to free while Pre-Auth returns to locked idle, and adjust the Step 6 guidance accordingly).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fix for #1