fix: allow running without HTTPS - #3195
Conversation
33d0578 to
aded3a2
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
betulependule
left a comment
betulependule
left a comment
There was a problem hiding this comment.
LGTM, but my understanding of OpenShift is limited, so consider asking for an additional review from someone with a deeper understanding.
We haven’t gotten to the OpenShift changes yet… I have a feeling that most of those will need to be done in the deployment repo. |
As part of PACKIT-5356 we need to be able to run the container without providing the SSL/TLS itself, as it will be provided by the OpenShift. This should allow us to conditionally let the ‹mod_wsgi-express› handle the SSL/TLS, if there are certificates provided, otherwise just use plain HTTP and let the reverse proxy / OpenShift handle it. Fixes PACKIT-5356 Assisted-by: gpt-5.6-luna medium Signed-off-by: Matej Focko <mfocko@packit.dev>
aded3a2 to
993c11b
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 55s |
4 participants
As part of PACKIT-5356 we need to be able to run the container without providing the SSL/TLS itself, as it will be provided by the OpenShift.
This should allow us to conditionally let the ‹mod_wsgi-express› handle the SSL/TLS, if there are certificates provided, otherwise just use plain HTTP and let the reverse proxy / OpenShift handle it.
Fixes PACKIT-5356