perf(IT-Wallet): [SIW-000] Improve proximity QR code screen performance - #8530
Draft
mastro993 wants to merge 1 commit into
Draft
perf(IT-Wallet): [SIW-000] Improve proximity QR code screen performance#8530mastro993 wants to merge 1 commit into
mastro993 wants to merge 1 commit into
Conversation
Defer react-native-qrcode-skia until after the skeleton paints so SVG path generation does not block the first frame. Memoize QR props so the path is built once.
mastro993
requested review from
a team,
Leerti,
emilio-dimari,
gispada and
soixdev91
as code owners
September 2, 2026 09:07
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8530 +/- ##
==========================================
- Coverage 64.39% 64.38% -0.02%
==========================================
Files 1996 1996
Lines 38129 38147 +18
Branches 6458 6461 +3
==========================================
+ Hits 24553 24560 +7
- Misses 12155 12167 +12
+ Partials 1421 1420 -1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Contributor
|
@mastro993 I honestly see a worse situation here.
IMG_0066.MP4 |
mastro993
marked this pull request as draft
September 2, 2026 12:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Reduce hitching when opening the IT Wallet proximity QR code screen, while still rendering the QR with
react-native-qrcode-skia.List of changes proposed in this pull request
react-native-qrcode-skiauntil after the skeleton has painted, so SVG path generation does not block the first frameshapeOptions, logo, size) so the path is built once instead of on every parent re-renderHow to test
QRCodefirst mount still does the library's SVG path work (~120ms), isolated after the skeleton paint