Skip to content

feat(IT-Wallet): [SIW-4914] Implement independent dismiss state for new credential validity banners - #8534

Merged
ale-mazz merged 4 commits into
masterfrom
SIW-4914
Sep 8, 2026
Merged

feat(IT-Wallet): [SIW-4914] Implement independent dismiss state for new credential validity banners#8534
ale-mazz merged 4 commits into
masterfrom
SIW-4914

Conversation

@ale-mazz

@ale-mazz ale-mazz commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Short description

Makes the "attestation validity" banner and the "Tessera Sanitaria" (EHC) banner dismissable on the IT-Wallet credential detail page, aligning them with the same pattern already used by other banners on that screen (shared "Lo sapevi?" title).

List of changes proposed in this pull request

  • Converted ItwPresentationNewCredentialValidityAlert from a non-dismissable Alert to a dismissable Banner, with the title "Lo sapevi?"
  • Converted the TS (Tessera Sanitaria) banner in ItwPresentationCredentialInfoAlert from Alert to a dismissable Banner, with the title "Lo sapevi?" (banner id renamed to tsDetailsInfo for consistency with the existing credentialName.ts key)
  • Introduced a scalable banner id based on a template literal (newCredentialValidity:${credentialType}), so every future credential type automatically gets its own persisted dismiss state without touching the reducer/selector
  • Added a defaultBannerHideDuration fallback for banner ids without an explicit entry in bannerHideDurations
  • Added the title: "Lo sapevi?" locale key for newCredentialValidityAlert and for the new alerts.ts

How to test

  1. Open the detail screen of a credential with the "attestation validity" banner (e.g. residency attestation/education title) and verify it shows the "Lo sapevi?" title and can be dismissed via the close icon
  2. Dismiss the banner and verify it doesn't reappear when reopening the screen (state persisted in Redux)
  3. Repeat the same test on the Tessera Sanitaria (TS) banner in the TS credential detail screen
  4. Verify that banners for different credential types keep indep
    endent dismiss states

Preview

IMAGE 2026-09-02 15:10:39 IMAGE 2026-09-02 15:10:31

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Jira Pull Request Link

This Pull Request refers to Jira issues:

@ale-mazz ale-mazz self-assigned this Sep 2, 2026
@ale-mazz
ale-mazz marked this pull request as ready for review September 2, 2026 13:11
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.02%. Comparing base (d1def68) to head (a1054ed).

Files with missing lines Patch % Lines
.../components/ItwPresentationCredentialInfoAlert.tsx 50.00% 1 Missing and 1 partial ⚠️
...eatures/itwallet/common/store/selectors/banners.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8534   +/-   ##
=======================================
  Coverage   65.01%   65.02%           
=======================================
  Files        2005     2005           
  Lines       38406    38420   +14     
  Branches     6556     6559    +3     
=======================================
+ Hits        24969    24981   +12     
- Misses      12004    12005    +1     
- Partials     1433     1434    +1     
Files with missing lines Coverage Δ
...features/itwallet/common/store/reducers/banners.ts 100.00% <100.00%> (ø)
...ents/ItwPresentationNewCredentialValidityAlert.tsx 100.00% <100.00%> (ø)
...eatures/itwallet/common/store/selectors/banners.ts 88.88% <66.66%> (+0.31%) ⬆️
.../components/ItwPresentationCredentialInfoAlert.tsx 76.00% <50.00%> (-4.96%) ⬇️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1def68...a1054ed. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread apps/main-app/ts/features/itwallet/common/store/reducers/banners.ts Outdated

@mastro993 mastro993 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	pnpm-lock.yaml
@ale-mazz
ale-mazz added this pull request to the merge queue Sep 8, 2026
Merged via the queue into master with commit c43d33e Sep 8, 2026
13 checks passed
@ale-mazz
ale-mazz deleted the SIW-4914 branch September 8, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants