Conversation
…ew credential validity banners
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
ale-mazz
marked this pull request as ready for review
September 2, 2026 13:11
ale-mazz
requested review from
a team,
Leerti,
emilio-dimari,
gispada and
soixdev91
as code owners
September 2, 2026 13:11
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8534 +/- ##
=======================================
Coverage 65.01% 65.02%
=======================================
Files 2005 2005
Lines 38406 38420 +14
Branches 6556 6559 +3
=======================================
+ Hits 24969 24981 +12
- Misses 12004 12005 +1
- Partials 1433 1434 +1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
gispada
reviewed
Sep 3, 2026
# Conflicts: # pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Makes the "attestation validity" banner and the "Tessera Sanitaria" (EHC) banner dismissable on the IT-Wallet credential detail page, aligning them with the same pattern already used by other banners on that screen (shared "Lo sapevi?" title).
List of changes proposed in this pull request
ItwPresentationNewCredentialValidityAlertfrom a non-dismissableAlertto a dismissableBanner, with the title "Lo sapevi?"ItwPresentationCredentialInfoAlertfromAlertto a dismissableBanner, with the title "Lo sapevi?" (banner id renamed totsDetailsInfofor consistency with the existingcredentialName.tskey)newCredentialValidity:${credentialType}), so every future credential type automatically gets its own persisted dismiss state without touching the reducer/selectordefaultBannerHideDurationfallback for banner ids without an explicit entry inbannerHideDurationstitle: "Lo sapevi?"locale key fornewCredentialValidityAlertand for the newalerts.tsHow to test
endent dismiss states
Preview