refactor: [IOPLT-1528] Add IOTypography as single source of truth - #8553
Open
dmnplb wants to merge 7 commits into
Open
refactor: [IOPLT-1528] Add IOTypography as single source of truth#8553dmnplb wants to merge 7 commits into
IOTypography as single source of truth#8553dmnplb wants to merge 7 commits into
Conversation
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
dmnplb
marked this pull request as ready for review
September 7, 2026 12:18
dmnplb
requested review from
a team,
Leerti,
emilio-dimari,
gispada and
soixdev91
as code owners
September 7, 2026 12:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8553 +/- ##
==========================================
- Coverage 64.87% 64.87% -0.01%
==========================================
Files 2000 2000
Lines 38247 38247
Branches 6531 6531
==========================================
- Hits 24814 24812 -2
- Misses 12004 12006 +2
Partials 1429 1429
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
All the typographic attributes now live in one
IOTypographyobject incore/, which the components themselves read. Values are unchanged: the existing typography snapshots pass untouched.Motivation
Every style pinned its attributes inside its own component, and only some of them were re-exported as loose constants.
Herois the clearest symptom: it exportedheroFontSize/heroLineHeightand then ignored them. Anyone who needs a style's metrics outside aTexthas had to copy the numbers and hope they stay in sync.List of changes proposed in this pull request
IOTypographyincore/, with every style's font, size, line height, weight, iOS Dynamic Type ramp, letter spacing/transform and default color tokenh1FontSize,bodyLineHeight, …) and migrate every call site.18value to theIOFontSizescale (referenced byMdH2)IOTypographicLinkColorToken, shared byBody,BodySmall,LabelMiniandIOMarkdownREADMEand the mainREADMEto reflect the new changes.Important
This PR introduces breaking changes for the published package: the next DS release needs a major bump.
How to test
pnpm nx test @pagopa/io-app-design-system: snapshots must pass unchanged (any snapshot diff means a value drifted during the move)master, in both light and dark themeIDPayscreens that used the old constants: Barcode result and the static code modal, including their skeleton placeholdersH6still switches to17px