feat(web): 가능 시간 관리 UI 개선 - #105
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Walkthrough
Changes캘린더 다이얼로그 기반 근무 기간 선택 및 드래그 셀 선택
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/features/availability/components/mvp-availability-page.tsx`:
- Line 805: The `DialogContent` in `mvp-availability-page.tsx` uses an arbitrary
Tailwind width value (`max-w-[420px]`), which should be replaced with a standard
Tailwind size token or a shared `globals.css` token if that exact width is
required; update the `DialogContent` class accordingly and keep the width
consistent with the project’s sizing scale. Also review the nearby `text-[10px]`
usage in the same component for the same tokenization rule, and prefer a named
token or default scale where possible.
- Around line 438-446: The derived date arrays in mvp-availability-page.tsx are
being recomputed on every render, and repeated getSchedulableRanges calls in the
closedDates, datesWithoutStaffingRules, and visibleTimetableDates calculations
are causing unnecessary work during drag-driven rerenders. Move these three
filters into useMemo alongside the existing memoized
dateRange/timetableRange/timeSlots/calendarDates, and use the same
businessHours, staffingRules, and dateRange dependencies so the results are
reused when inputs haven’t changed. Keep the logic in the MVPAvailabilityPage
component, and preserve the current semantics while reducing the render hot-path
cost.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 7c660ada-cb15-47d4-9e3c-84afdd85afed
📒 Files selected for processing (1)
apps/web/src/features/availability/components/mvp-availability-page.tsx
2 participants
개요
가능 시간 관리 화면의 근무 기간 설정과 근무자별 가능 시간 입력 UX를 개선합니다.
변경 사항
변경 유형
feat— 새로운 기능fix— 버그 수정refactor— 리팩터링 (기능 변경 없음)test— 테스트 코드perf— 성능 개선docs— 문서 수정chore— 빌드·설정 변경영향 범위
web—apps/webapi—apps/apidb—packages/databaseshared—packages/sharedrepo— 루트 설정·CI/CD·문서테스트 방법
pnpm --filter @fragment/web typecheck체크리스트
packages/shared) 업데이트 (타입 변경 시)스크린샷 / 영상
UI 변경 사항은 로컬 화면에서 확인했습니다.
리뷰 포인트
Summary by CodeRabbit
New Features
익일 HH:MM형식으로 더 직관적으로 표시됩니다.Bug Fixes