Skip to content

chore: start 1.23.0-SNAPSHOT - #172

Merged
pando85 merged 2 commits into
mainfrom
chore/1.23.0-snapshot
Sep 21, 2026
Merged

pando85 merged 2 commits into
mainfrom
chore/1.23.0-snapshot

Conversation

@forkline-bot

@forkline-bot forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

Bump version to 1.23.0-SNAPSHOT to begin the next development cycle after the 1.22.0 release.


This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

forkline-dev[bot] added 2 commits September 21, 2026 05:22
requireNotNull was wrapping .toInt() (non-nullable Int) instead of
getProperty() (nullable String), making the error message unreachable.
Move .toInt() outside requireNotNull so the null check works as intended.
@forkline-bot

forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown
Author

Maintainability Review

Initial expected implementation: matched
Initial reason: version.properties correctly set to 1.23.0-SNAPSHOT (versionCode=12300), CHANGELOG has empty [Unreleased] section above 1.22.0, and auto-tag workflow correctly skips SNAPSHOT versions.
Applied maintenance work: Fixed requireNotNull ordering bug in VersioningPlugin.
Final implementation: matches
Validation: build-logic compiles successfully, spotless formatting passes.


Finding 1: requireNotNull wraps wrong expression

  • Priority: medium
  • Category: bug
  • Decision: applied
  • Location: build-logic/.../versioning/VersioningPlugin.kt:43
  • Problem: requireNotNull was wrapping .toInt() (returns non-nullable Int) instead of getProperty() (returns nullable platform type). The custom error message was unreachable — a missing property would NPE at .toInt() before requireNotNull could fire.
  • Action: Moved .toInt() outside requireNotNull so the null check on the property value works as intended.
  • Why it is worth it: Corrects broken error handling with a one-line change; zero behavioral change when the property exists.
  • Risk / scope: Minimal — build-logic only, no runtime app impact.

@pando85
pando85 enabled auto-merge September 21, 2026 05:33
@pando85
pando85 merged commit b6c8842 into main Sep 21, 2026
5 checks passed
@pando85
pando85 deleted the chore/1.23.0-snapshot branch September 21, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant