Skip to content

release: 1.23.0 - #173

Closed
forkline-bot[bot] wants to merge 1 commit into
mainfrom
release/1.23.0
Closed

forkline-bot[bot] wants to merge 1 commit into
mainfrom
release/1.23.0

Conversation

@forkline-bot

@forkline-bot forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown

Release 1.23.0

Fixed

  • Corrected requireNotNull ordering in VersioningPlugin so null checks work as intended

This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

@forkline-bot

forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown
Author

Maintainability Review

Initial expected implementation: matched
Initial reason: PR description states "Corrected requireNotNull ordering in VersioningPlugin so null checks work as intended" — the fix commit (df28be4e) correctly moves .toInt() outside requireNotNull so the null check on getProperty() is reachable.
Applied maintenance work: none
Final implementation: matches
Validation: build-logic:compileKotlin passes

Findings

Priority: low
Category: bug
Decision: do not pursue
Location: VersioningPlugin.kt:46.toInt() after requireNotNull
Problem: If the property exists but contains a non-integer value, .toInt() throws NumberFormatException without a helpful message. However, the property file is auto-generated by VersioningTask, so this is extremely unlikely in practice.
Why not worth it: Auto-generated input makes this a theoretical risk; adding toIntOrNull + another requireNotNull adds complexity for negligible payoff.
Risk/scope: trivial change but no meaningful reliability gain

@pando85 pando85 closed this Sep 21, 2026
@pando85
pando85 deleted the release/1.23.0 branch September 21, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant