Skip to content

release: Version 0.19.3 - #501

Merged
pando85 merged 2 commits into
masterfrom
release/v0.19.3
Sep 21, 2026
Merged

pando85 merged 2 commits into
masterfrom
release/v0.19.3

Conversation

@forkline-bot

@forkline-bot forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Release v0.19.3

Patch release with bug fix and dependency updates.

Fixed

Build

  • Updated multiple Rust crate dependencies (psl, dirs, prs-lib, toml, clap, clap_complete, syn)
  • Updated @simplewebauthn/server to v14.0.2
  • Updated commitlint pre-commit hook to v9.27.0

This PR was generated by Forkline — AI-powered code contributions.
The agent analyzed the issue and implemented this fix autonomously.

@pando85
pando85 enabled auto-merge (squash) September 21, 2026 05:10
The commit message for addb647 claimed this fix was applied but the
parameter type was not actually changed. &Path is the idiomatic Rust
type for function parameters accepting path references.
@forkline-bot

forkline-bot Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Maintainability Review

Initial expected implementation: differed
Initial reason: commit addb647 message claims "fix: use &Path instead of &PathBuf in initialize_git_repo parameter" but the parameter was never actually changed from \&PathBuf to \&Path.
Applied maintenance work: Fixed \&PathBuf\&Path in initialize_git_repo (store_initialized.rs:41).
Final implementation: matches
Validation: cargo check, cargo clippy -- -D warnings, cargo fmt --check, cargo test — all pass.


Findings

Priority: medium
Category: implementation gap
Decision: applied
Location: cmd/passless/src/storage/pass/init/store_initialized.rs:41
Problem: initialize_git_repo accepted store_path: &PathBuf instead of the idiomatic &Path. The commit message for addb647 explicitly stated this was fixed, but the change was never applied.
Action: Changed parameter type to &Path.
Why it is worth it: Aligns code with the documented intent and Rust API guidelines (&Path is more general and accepted by all callers).
Risk / scope: Minimal — single parameter, no behavior change.


Priority: low
Category: refactor
Decision: recommend, but defer
Location: cmd/passless/src/storage/pass/init/mod.rs:40
Problem: e.to_string().contains("ALREADY_INITIALIZED") uses string matching on error messages for control flow. If the error message format changes, this silently breaks.
Action: Consider introducing a dedicated error variant (e.g., Error::AlreadyInitialized) or returning Result<Option<Self>> from check_if_initialized instead of encoding control flow in error strings.
Why it is worth it: Eliminates a fragile string-matching pattern that could silently regress.
Risk / scope: Low effort but touches the error enum and multiple call sites; better suited for a follow-up.

@pando85
pando85 merged commit 3a8150b into master Sep 21, 2026
8 checks passed
@pando85
pando85 deleted the release/v0.19.3 branch September 21, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant