Map forced tool choice onto the Groq API - #2
Merged
Merged
Conversation
Groq was left out of the v0.13 toolChoice release, so it accepted the option and silently dropped it. Its API is OpenAI-compatible, so the mapping matches the six providers already shipped: auto, none, required, or the function form for a named tool. Validation stays in core and throws before any HTTP call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groq never received the v0.13
toolChoicework, so until now it accepted the option and silently dropped it: the caller's guarantee was quietly broken rather than honoured or refused.Groq's API is OpenAI-compatible, documented as accepting
none,auto,requiredand{"type":"function","function":{"name":...}}, so this is the same mapping as deepseek and openai. Validation stays in core'sToolChoice::fromOption()and throws before any HTTP call.7 new tests.
composer cigreen locally.