fix(server): recheck inclusion instead of re-broadcasting on watch stop#307
Open
valentinfernandez1 wants to merge 3 commits into
Open
fix(server): recheck inclusion instead of re-broadcasting on watch stop#307valentinfernandez1 wants to merge 3 commits into
valentinfernandez1 wants to merge 3 commits into
Conversation
valentinfernandez1
marked this pull request as ready for review
July 22, 2026 19:10
nightly clippy (result_large_err) rejects the bare 240-byte subxt::Error in block_inclusion_outcome's Err variant.
pgherveou
reviewed
Jul 23, 2026
Collaborator
|
Question: instead of re-signing and re-submitting. why not re-trying the already signed tx? build/sign Only rebuild after proving the original expired or was never included and its nonce remains unused. Can you comment on whether it make sense or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A
chainHead_followstopaborts subxt's transaction watch without saying anything about the transaction itself, which may already be on chain.Before,
Preimage.submittreated this like any other uncertain watch failure: retry once by re-signing and re-broadcasting. If the first transaction had actually landed, that stored the preimage twice and burned allowance for nothing; if the retry also errored, the call failed even though the submission had succeeded.Now, when the watch dies without a verdict, the extrinsic is looked up in the next few finalized blocks first. Found on chain: its dispatch outcome is taken from the block events and nothing is re-broadcast. Not found: the old single-retry behavior applies unchanged. Definitive node verdicts (invalid, dropped) skip the re-check entirely.