Skip to content

fix: cleanUp config and removed the ingestUrl#112

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
pratik50:fix/cleanUpConfigFile
Jul 21, 2026
Merged

fix: cleanUp config and removed the ingestUrl#112
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
pratik50:fix/cleanUpConfigFile

Conversation

@pratik50

@pratik50 pratik50 commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Clean Up

  • removed the ingest conifig from the pb config.go

Summary by CodeRabbit

  • Improvements
    • Simplified cloud profile configuration by removing the obsolete ingest URL field.
    • Updated profile validation and authentication data handling to use the profile URL, workspace details, tenant information, and token settings.
    • Removed ingest URL values from safe profile output.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ae7fa613-6173-401e-8ca3-1f2bad4a98d9

📥 Commits

Reviewing files that changed from the base of the PR and between 9486fd1 and 2cca623.

📒 Files selected for processing (4)
  • cmd/cloud.go
  • cmd/login.go
  • cmd/profile.go
  • pkg/config/config.go
💤 Files with no reviewable changes (4)
  • cmd/profile.go
  • cmd/login.go
  • pkg/config/config.go
  • cmd/cloud.go

📝 Walkthrough

Walkthrough

Cloud profile handling removes IngestURL from configuration, API-key validation mapping, profile creation, and safe profile output while retaining workspace, tenant, orchestrator, and profile URL fields.

Changes

Cloud profile schema and propagation

Layer / File(s) Summary
Update profile contract
pkg/config/config.go, cmd/profile.go
config.Profile and safe profile output no longer include the ingest URL field.
Update cloud profile creation
cmd/cloud.go, cmd/login.go
Cloud API-key validation includes workspace name and profile URL fields, and profile creation no longer assigns an ingest URL.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • parseablehq/pb#110: Introduced the cloud API-key login and profile creation paths modified here.
  • parseablehq/pb#111: Also changes the cloud API-key validation flow in cmd/cloud.go.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing the ingest URL from config and profile handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit 6bfb15c into parseablehq:main Jul 21, 2026
3 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants