chore: bump plugin-bones — the outside heat pump always ships - #700
Merged
Conversation
User report: the outdoor unit vanished at LOD 200/300 (the block was fabrication-gated while AH+ducts ship at every level) and on footprints with no straight exterior wall. Now: outdoor block at every LOD, loud placement/disconnect warnings, 1500-compose invariant gate. 1059 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the user report "sometimes the hvac does not add the outside heat pump."
Root cause (2,700-compose sweep): the whole outdoor block (unit/pad/disconnect/whip/line-set) was gated behind detail 400 while the air handler and ducts ship at every LOD — the panel's LOD knob silently removed the heat pump. Also fixed: silent skips on no-exterior-wall footprints and unresolvable heat-pump service nodes.
Contract now gated across 1,500 composes: an air handler always implies ≥1 outdoor unit, or a warning names the reason. Skeptic + examiner APPROVE; baseline byte-identical.
🤖 Generated with Claude Code
Note
Low Risk
Dependency pin only; no local logic, auth, or data-handling changes. Risk is limited to whatever the new plugin-bones commit does at compose time.
Overview
Pins
@pascal-app/plugin-bonesto73c0812so HVAC composes always include the outdoor heat pump (unit, pad, disconnect, whip, line-set) instead of dropping it when LOD is below detail 400.Also picks up plugin-side handling for no-exterior-wall footprints and unresolvable heat-pump service nodes, with a compose contract that an air handler implies at least one outdoor unit (or a named warning).
Reviewed by Cursor Bugbot for commit a201393. Bugbot is set up for automated code reviews on this repo. Configure here.