An EventGraph with tests#316
Closed
vineetbansal wants to merge 2 commits into
Closed
Conversation
Collaborator
Author
|
Closing this in favor of an upcoming PR originating from this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced an
EventGraphclass with tests to illustrate basic functionality.EventGraphis a pathpyGGraphso in addition to being constructed from aTemporalGraph, it is capable of being constructed directly from atorch_geometric.data.Dataobject.Essentially the usage might be:
A couple of things to discuss:
If an
EventGraphis constructed from aTemporalGraphand theTemporalGraphis later changed by the caller, should theEventGraphchange as well? Right now we don't -eg._temporal_graph = TemporalGraph(g.data.clone(), mapping=g.mapping). This seems to me like the right thing to do.eg.shortest_pathsworks, but creates aTemporalGraph(if it doesn't exist) to pass on totemporal_shortest_paths. This seems wasteful ifEventGraphwas constructed fromDataand doesn't need all theTemporalGraphmachinery. Perhapstemporal_shortest_pathscan be tweaked to work with a pre-computed edge-index (as would be the case ifEventGraphis constructed directly fromtorch_geometric.data.Data).temporal_shortest_paths(g: TemporalGraph | None, eg: "EventGraph" | None, delta: int). Add methods toEventGraph/TemporalGraphthat call this function under the hood.Some changes in other files were for my understanding of the code by adding comments, and are unrelated to the PR.