stop clipping rejected steps to t1#758
Merged
patrick-kidger merged 1 commit intoJun 2, 2026
Merged
Conversation
Owner
|
LGTM! Merged 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_clip_to_endpreviously overrode the PID controller on a rejected step with a fixed midpoint that is also rejected; on rejection tprev doesn't advance, so the midpoint is constant, and the same too-large step gets retried forever.The midpoint override's only justification was floating-point stability of dense interpolation against the old fixed 1e-6 tolerance. #660 replaced that with 100 * ULP(t1), which is directly related to the float resolution boundary. This PR just drops that branch and trusts the controller's shrunken proposal on rejection. The #85 fix (only snap-to-t1 on accepted steps) is preserved.
Regression coverage: