Skip to content

Apply limiter after refinement/coarsening for T8codeMesh - #50

Merged
patrickersing merged 3 commits into
patrickersing:amr_limiterfrom
bennibolm:amr_limiter_t8codemesh
Sep 13, 2025
Merged

Apply limiter after refinement/coarsening for T8codeMesh#50
patrickersing merged 3 commits into
patrickersing:amr_limiterfrom
bennibolm:amr_limiter_t8codemesh

Conversation

@bennibolm

@bennibolm bennibolm commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Add support for T8codeMesh
see trixi-framework#2396
I am not an expert with T8codeMesh. So if there are any special features, I have probably forgotten to take them into account.
We could also do this in a different PR.

@github-actions

github-actions Bot commented Sep 3, 2025

Copy link
Copy Markdown

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@bennibolm bennibolm mentioned this pull request Sep 3, 2025
Merged
patrickersing
patrickersing reviewed Sep 8, 2025
View reviewed changes

@patrickersing patrickersing left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extension to T8codeMesh!
I looked over the changes and besides some minor suggestions everything looks good from my end.
However, I have no experience with T8codeMesh, so it would be great if someone familiar with T8codeMesh could have a final look specifically over the compute_new_ids_refined_coarsened_elements! function.

Comment thread src/callbacks_step/amr.jl
Comment thread src/callbacks_step/amr.jl Outdated
Comment thread src/callbacks_step/amr.jl
patrickersing
patrickersing approved these changes Sep 13, 2025
View reviewed changes

@patrickersing patrickersing left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickersing
patrickersing merged commit 7b8d2ab into patrickersing:amr_limiter Sep 13, 2025
8 of 35 checks passed
amrueda pushed a commit that referenced this pull request Jul 30, 2026
@patrickersing @andrewwinters5000
@bennibolm @DanielDoehring @ranocha
Add positivity-limiter to the AMRCallback (trixi-framework#2396)
d0b79c3 
* add positivity limiter to the amr callback

* remove duplicate limiter! argument

* Update src/callbacks_step/amr.jl

Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>

* Implement synchronized shifting for child elements

* Implement synchronized shifting for child elements

* Fix increase of `element_id`

* Revise implementation with mean value of parent element

* Add 1D and 3D

* Remove if and use dispatching

* Decrease theta by eps()

* Implement first suggestions

* Compute mean within `limiter !== nothing`

* Add suggested comment

* Restructure call of limiter for refined elements

* Implement suggestions

* Implement thread parallel version; Add timer

* Remove `@assert`

* Add function for coarsened elements

* Fix dimension

* Add auxiliary functions to compute new elements ids

* Fix function name

* Use `compute_u_mean`; Update docstring

* Use `compute_u_mean` in limiter after coarsening

* Rename function

* Implement suggestions

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Apply suggestions from code review

* Update src/callbacks_stage/positivity_zhang_shu_dg2d.jl

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Update src/callbacks_stage/positivity_zhang_shu_dg1d.jl

* Apply suggestions from code review

* Rename for-variables; Remove comments

* Remove codes as suggested

* add comment for amr positivity-limiting

* Apply limiter after refinement/coarsening for T8codeMesh (#50)

* Apply limiter after refinement/coarsening with T8codeMesh

* Implement suggestions

* doc

* Add simple tests

* Update test/test_unit.jl

* Update src/callbacks_step/amr.jl

* Remove dispatching

* Use Array{T, 2} instead of Matrix{T}

* Add timer to computation of parent's mean value

* Fix tests (Set `periodicity` and `boundary_conditions`)

* fix docs

* Add function for dimensions-independent code

* Add comment and source to elixirs

* Simplify variable names

* Apply `compute_u_mean_refined_elements` also for T8code

* Update NEWS.md

* Implement fiirst suggestions

* Add `theta=max(0, theta)` to tutorial

* Fix error in documentation

* fix merge conflict in NEWS.md

---------

Co-authored-by: Andrew Winters <andrew.ross.winters@liu.se>
Co-authored-by: Benjamin Bolm <74359358+bennibolm@users.noreply.github.com>
Co-authored-by: Daniel Doehring <doehringd2@gmail.com>
Co-authored-by: Hendrik Ranocha <ranocha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickersing patrickersing patrickersing approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bennibolm @patrickersing