PRE-3553 feat: Create admin payment method Unify Hosted Fields - #307
PRE-3553 feat: Create admin payment method Unify Hosted Fields#307hdelaforce-payplug wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository. To reconnect it, an admin of this repository's GitHub organization (or the account owner, for personal repositories) who can also manage your Claude organization's Code Review settings needs to re-link GitHub in Code Review settings. This is a one-time step.
Tip: disable this comment in your organization's Code Review settings.
Code reviewOverview Registers Against PRE-3553 acceptance criteria
Findings
Verdict Good to merge. Solid, convention-consistent implementation of an intentionally partial slice of the larger UHF migration. |
f5cd1e6 to
1a7ac8a
Compare
Description
Ajoute UHF (Unified Hosted Fields) comme moyen de paiement Sylius à part entière, distinct du gateway PayPlug existant et de son option "Integrated Payment" — les deux coexistent sans interférence.
payplug_uhf(UhfGatewayFactory+UhfGatewayConfigurationType), suivant le pattern déjà utilisé pour Wero/Scalapay.UnifiedAuthenticationController, PRE-3563) — aucune saisie manuelle, aucune modification du contrôleur nécessaire.hfIdentifierDefaultdans le formulaire admin.PaymentMethod/GatewayConfigSylius distinct.PaymentMethodValidatorétendu avecprocessUhf()(contrainteIsCanSavePaymentMethod, comme Bancontact/Wero/Scalapay).Hors périmètre (volontaire) :
command_provider,http_response) reste absent : c'est le pipeline legacy SDK, pas UPC — sera traité par PRE-3551 pour éviter qu'UHF ne tente de payer via le mauvais pipeline entre-temps.Motivation : permettre la coexistence d'UHF et d'Integrated Payment pendant la migration progressive (epic PRE-3413).
Related issue(s): Closes PRE-3553
Type of Change
Checklist
Code Quality
Testing
PaymentMethodValidatorTest,UhfGatewayConfigurationTypeTest)UhfGatewayConfigurationType::buildForm()etPaymentMethodValidator::processUhf()) ; SonarCloud Quality Gate attendu au vertSecurity & Ops
Point d'attention pour le reviewer :
CanSavePayplugPaymentMethodChecker::isEnabled()dériveuhfdu factory name et interrogepayment_methods.uhf.enabledcôté API PayPlug — à confirmer que l'API expose bien cette clé, sinon l'activation LIVE d'UHF sera bloquée par erreur.