Modifications - #53
Closed
wmbutler wants to merge 13 commits into
Closed
Conversation
Contributor
|
@wmbutler I think it would be best to add this functionality as an opt-in option instead of having it on by default, to prevent breaking changes. |
Author
|
I saw your comment after this. So, maybe a flag called |
Contributor
|
@wmbutler might be better to add an options object when you require the library. |
Author
|
I'm not sure I follow. |
Contributor
Contributor
Author
|
Closing this in response to @whitef0x0 pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is the correct pull request. Sorry, I made some readme changes on my version that would have been wrong on yours.