Update PebbleKit Android section to V2#110
Open
matejdro wants to merge 2 commits into
Open
Conversation
Signed-off-by: Matej Drobnic <matej@matejdro.com>
Signed-off-by: Matej Drobnic <matej@matejdro.com>
Contributor
|
cc: @Sorixelle |
Member
|
I'm not super keen on doing this as a submodule. I suspect at some point, we'll want to do some Javadoc-based docs generation like what we do with the old PebbleKit Android stuff, so it's probably better to do this as a checkout during CI, and then copying files to where they need to go when building. Bonus points for some CI in the PKA2 repo to automatically build Javadocs and produce an artifact on releases - that's what I would like to work towards for the CI here, personally. |
Contributor
Author
|
What if we just link to the Github page instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #109, this includes the PK2 Android as a submodules and includes its readme, replacing the old outdated PebbleKit Android documentation.
Issues from this approach:
There is still https://developer.rebble.io/docs/pebblekit-android/, but it seems a bit involved to replace, so I have decided to leave it for now.
fixes #109