Reject revoked remotely resolved signing keys#3
Open
Mirochill wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activeandrotatedkeysrevokedkeys before their key material can be usedWhy
The public key-rotation documentation states that historical
rotatedkeys remain usable for verification, whilerevokedkeys must fail immediately. The resolver previously selected a remote key by id and ignored the returned lifecycle metadata, allowing a matching revoked Ed25519 key to verify receipts successfully.Fixes permission-protocol/deploy-gate#50.
Related bounty: permission-protocol/deploy-gate#36.
Validation
npm testnpm run buildgit diff --checkKEY_RESOLUTION_FAILEDwith exit code4