fix: validate Ed25519 key type and specify explicit algorithm (Fixes #52)#6
Open
zeroknowledge0x wants to merge 1 commit into
Conversation
- Add asymmetricKeyType check to reject non-Ed25519 keys (RSA, ECDSA, Ed448) - Pass 'ed25519' explicitly to crypto.verify() instead of null - Prevents algorithm confusion where non-Ed25519 signatures pass verification - Fixes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #52 — the reference verifier accepted non-Ed25519 signatures (RSA, ECDSA, Ed448) while reporting them as verified Ed25519 receipts.
Root Cause
verifySignature(null, ...)withnullas the algorithm parameter causes Node.js to infer the algorithm from the key type. This means any key type that passescrypto.verify()would be accepted, regardless of whatsignatureAlgclaims.Changes
keyResult.key.asymmetricKeyTypeand reject if noted25519'ed25519'tocrypto.verify()instead ofnullTesting