Conversation
Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
Signed-off-by: aviralgarg05 <gargaviral99@gmail.com>
|
hello @aviralgarg05 , quick question: which version of jaeger API are we using for this plugin? I heard the most adopt jaeger API is actually their internal http API. Grafana is also using that API. And they have a public gRPC API but it's still a WIP for switching Grafana data source to that. Background: I'm from http://github.com/GreptimeTeam/ and our database has compatibility for jaeger's http API. So if this patch is using that one, we won't need to create our own trace data source. |
Hi, this plugin is using Jaeger’s HTTP API, not the gRPC API. Right now it talks to the same HTTP endpoints Jaeger exposes for its UI / datasource integrations, mainly:
So if your compatibility layer implements Jaeger’s HTTP API for those endpoints and response shapes, this plugin should work with it without needing a separate datasource. I have not added any dependency on Jaeger’s public gRPC API in this PR. |
|
@aviralgarg05 Perfect! All these endpoints are supported by GreptimeDB. Thank you for clarification. |
|
@aviralgarg05 there is a small issue with the cue formatting. The rest LGTM |
Description
This pull request adds a new Jaeger plugin to the
pluginsrepository so Perses can query and display traces coming from Jaeger.The implementation covers both main Jaeger trace workflows:
The plugin then converts Jaeger responses into the trace data format expected by Perses trace visualizations, so the result can be used in trace-related panels without requiring any special handling elsewhere.
A few points worth calling out for review:
This change is intended to address the Jaeger support requested in the linked issue and follow-up discussion.
Closes perses/perses#3409
Context: perses/perses#3993
Screenshots
UI changes are limited to the new datasource and trace query editors for the Jaeger plugin.
No screenshots are attached here.
Checklist
[<catalog_entry>] <commit message>naming convention using one of the followingcatalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes