[FEATURE] Add optional projectName prop to ViewExplore#104
Open
rickardsjp wants to merge 1 commit intoperses:mainfrom
Open
[FEATURE] Add optional projectName prop to ViewExplore#104rickardsjp wants to merge 1 commit intoperses:mainfrom
rickardsjp wants to merge 1 commit intoperses:mainfrom
Conversation
Thread the already-existing DatasourceStoreProvider projectName prop through ViewExplore so consumers can scope the explore view to a specific project's datasources. Signed-off-by: Jeremy Rickards <jeremy.rickards@sap.com>
rickardsjp
force-pushed
the
explore-project-name
branch
from
c265e16 to
017b729
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DatasourceStoreProvideralready accepts aprojectNameprop (every dashboard uses it), butViewExplorewasn't forwarding it, so explore was limited to global datasources. This threads the prop through as an optional addition toViewExploreProps.Existing consumers are unaffected since the prop defaults to
undefined.Relates to perses/perses#3005
Screenshots
n/a: No visual change. The prop is consumed by the Perses app layer which provides the UI.
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
n/a: No direct UI changes in this PR. UI is provided by the consuming app.