#128 - email and phone don't appear after successful authentication with prn

[twilightily]

📌 Description

• To remove scraping of user's email and phone number when authenticating.
• Increases privacy

Fixes #128

🧱 Type of Change

• 🐛 Bug fix – Non-breaking fix for a functional/logic error
• [✅ ] ✨ New feature – Adds functionality without breaking existing APIs
• ⚠️ Breaking change – Introduces backward-incompatible changes (API, schema, etc.)
• 📝 Documentation update – README, docstrings, OpenAPI tags, etc.
• 🧪 Test suite change – Adds/updates unit, functional, or integration tests
• ⚙️ CI/CD pipeline update – Modifies GitHub Actions, pre-commit, or Docker build
• 🧹 Code quality / Refactor – Improves structure, readability, or style (no functional changes)
• 🐢 Performance improvement – Speeds up auth, scraping, or reduces I/O
• 🕵️ Debug/logging enhancement – Adds or improves logging/debug support
• 🔧 Developer tooling – Scripts, benchmarks, local testing improvements
• 🔒 Security fix – Addresses auth/session/data validation vulnerabilities
• 🧰 Dependency update – Updates libraries in requirements.txt, pyproject.toml

🧪 How Has This Been Tested?

Please indicate how you tested your changes. Completing all the relevant items on this list is mandatory

• Unit Tests (tests/unit/)
• Functional Tests (tests/functional/)
• Integration Tests (tests/integration/)
• [ ✅] Manual Testing

⚙️ Test Configuration:

• OS: Windows
• Python: 3.13
• Docker build tested

✅ Checklist

Please indicate the work items you have carried out. Completing all the relevant items on this list is mandatory. Anything left unchecked will be assumed to be non-relevant

• [✅ ] My code follows the CONTRIBUTING.md guidelines
• [✅ ] I've performed a self-review of my changes
• I've added/updated necessary comments and docstrings
• I've updated relevant docs (README or endpoint docs)
• [✅ ] No new warnings introduced
• I've added tests to cover my changes
• All tests pass locally (scripts/run_tests.py)
• [✅ ] I've run linting and formatting (pre-commit run --all-files)
• Docker image builds and runs correctly
• Changes are backwards compatible (if applicable)
• Feature flags or .env vars updated (if applicable)
• I've tested across multiple environments (if applicable)
• Benchmarks still meet expected performance (scripts/benchmark/benchmark_requests.py)

🛠️ Affected API Behaviour

Please indicate the areas affected by changes introduced in your PR

• [✅ ] app/app.py – Modified /authenticate route logic
• [✅ ] app/pesu.py – Updated scraping or authentication handling

🧩 Models

• [ ✅] app/models/request.py – Input validation or request schema changes
• [✅ ] app/models/response.py – Authentication response formatting
• [✅ ] app/models/profile.py – Profile extraction logic

🐳 DevOps & Config

• Dockerfile – Changes to base image or build process
• .github/workflows/*.yaml – CI/CD pipeline or deployment updates
• pyproject.toml / requirements.txt – Dependency version changes
• .pre-commit-config.yaml – Linting or formatting hook changes

📊 Benchmarks & Analysis

• scripts/benchmark_auth.py – Performance or latency measurement changes
• scripts/analyze_benchmark.py – Benchmark result analysis changes
• scripts/run_tests.py – Custom test runner logic or behavior updates

📸 Screenshots / API Demos (if applicable)

[

Examples:

• Terminal output from a successful curl request (redact sensitive data)
• Screenshots of Postman/Bruno results
• GIF of the endpoint working in a browser
• JSON payloads (redact sensitive data)

🧠 Additional Notes (if applicable)

Use this space to add any final context or implementation caveats.

Examples:

• Edge cases or limitations to be aware of
• Follow-up work or tech debt to track
• Known compatibility issues (e.g., with certain Python versions)
• Any new issues this PR introduces or makes visible

[aditeyabaral]

Thank you for this, @twilightily — and apologies that it sat unreviewed for as long as it did. That's on us, not you.

We've decided not to go ahead with #128. Since the issue was filed we've concluded that email and phone need to stay in the profile response: they're a meaningful part of what makes the profile useful to downstream consumers, and taking them out would break a field set people already depend on. So this is a change of direction on our side, not a problem with your work — the approach you took was the right one for what the issue asked, and the implementation was sound.

Closing on that basis. For completeness: the branch had also drifted into conflict across app/models/, app/pesu.py and four test files after the camelCase migration in #151 and the "Know Your Class and Section" removal in #155, so it would have needed a rebase regardless — but the conflicts aren't why this is being closed. The decision is.

If you'd still like to contribute, I'd be happy to point you at something current and actively wanted — just say the word. Thanks again for the time you put into this.

[twilightily]

Hello! Yes actually I’d love to contribute. Do let me know what y’all need, I might get to it a few weeks later though.