Skip to content

added center of mass to Panda DH definition (and cleaned it up a bit)#304

Open
jenskober wants to merge 4 commits into
petercorke:mainfrom
jenskober:master
Open

added center of mass to Panda DH definition (and cleaned it up a bit)#304
jenskober wants to merge 4 commits into
petercorke:mainfrom
jenskober:master

Conversation

@jenskober

Copy link
Copy Markdown

In pull request #294 some of the inertia parameters were ported from the matlab version. The center of mass for the links was still missing (without which dynamics calculations will be wrong). I've added them here and also cleaned up the white space a bit.

@AunSiro AunSiro left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to suggest the same thing. However, it must be noted that the parameters come from https://github.com/marcocognetti/FrankaEmikaPandaDynModel which uses the axes as in https://frankaemika.github.io/docs/control_parameters.html, but the model here ignores the (7) axes and links the last solid to the (F) axes. Therefore, the center of mass of the last solid must be given in (F) coordinates.

Comment thread roboticstoolbox/models/DH/Panda.py Outdated
Co-authored-by: Anonymous Researcher <siro.moreno.martin@gmail.com>
@jenskober

jenskober commented Jul 12, 2022

Copy link
Copy Markdown
Author

@AunSiro Thanks! Indeed, both the marcocognetti and frankaemika DH definition include a static 8th joint for the flange, while here this is rolled into the 7th joint, so the center of mass needs to be updated.
The robotics-toolbox uses inertia around center of mass, so indeed only the center of mass changes.

@jenskober

Copy link
Copy Markdown
Author

should now be compatible with the latest version in master

@JeanElsner

Copy link
Copy Markdown

I too was about to suggest the same thing, before I saw your pull request. It would be great to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants