fix: harden TypeScript project and async detection - #713
Open
GDownes wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
desloppify scan --path libs/cognito-deploy-contractsin a TypeScript monorepo createstsconfig.desloppify.jsonat the repository root with a hard-codedextends: ./tsconfig.app.json. Library projects commonly owntsconfig.jsoninstead, so the unused detector type-checks the wrong project or falls back after a timeout.async_no_awaitsmell detector treats the first{in a multiline typed parameter as the function body. It therefore flags async declarations that contain directawaitexpressions whenever their argument uses an inline object type.Fixes
tsconfig.app.jsonortsconfig.json, create the temporary override beside it, and extend that config. If no TypeScript config exists, use the existing source-based fallback directly.await.Validation
pytest desloppify/languages/typescript/tests/test_ts_unused.py -q— 19 passedpytest desloppify/languages/typescript/tests/ -q— 429 passedpython -m pytest desloppify/tests/ -q— 5651 passed, 153 skipped, 3 unrelated Bash failuresasync_no_awaitfindings fell from 10 to 0