Conversation
This target is more analogous to the `reset` targets (`dev-lima-reset`, `reset-fixture-lima`, `reset-fixture-ec2`) than the `teardown` targets, which also remove the VMs.
Up to standards ✅🟢 Issues
|
📝 WalkthroughWalkthroughA make target was renamed from Changes
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
Makefile (1)
387-388: Consider a temporary compatibility alias fordev-teardown.Non-blocking suggestion: keeping
dev-teardownas a deprecated alias todev-resetfor one release cycle can prevent breaking local scripts while the new name rolls out.Proposed transitional alias
.PHONY: dev-reset dev-reset: dev-down # remove postgres and supported services ids=$$(docker service ls -q); \ if [ -n "$$ids" ]; then \ echo "$$ids" \ | xargs docker service inspect \ --format '{{.ID}} {{index .Spec.Labels "pgedge.component"}}' \ | awk '$$2=="postgres" || $$2=="service" {print $$1}' \ | xargs docker service rm; \ fi docker network ls \ --filter=scope=swarm \ --format '{{ .Name }}' \ | awk '$$1 ~ /-database$$/' \ | xargs docker network rm rm -rf ./docker/control-plane-dev/data + +.PHONY: dev-teardown +dev-teardown: + `@echo` "WARNING: 'dev-teardown' is deprecated; use 'dev-reset' instead." + @$(MAKE) dev-reset🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Makefile` around lines 387 - 388, Add a temporary compatibility alias called dev-teardown that depends on the new dev-reset target so existing scripts keep working; implement it as a .PHONY target named dev-teardown which either lists dev-reset as its prerequisite or invokes/makes dev-reset and optionally prints a short deprecation warning, keep this alias for one release cycle and then remove it when consumers have migrated.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@Makefile`:
- Around line 387-388: Add a temporary compatibility alias called dev-teardown
that depends on the new dev-reset target so existing scripts keep working;
implement it as a .PHONY target named dev-teardown which either lists dev-reset
as its prerequisite or invokes/makes dev-reset and optionally prints a short
deprecation warning, keep this alias for one release cycle and then remove it
when consumers have migrated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d1a8f8e1-86e2-4fdd-b687-21752c9316df
📒 Files selected for processing (3)
CLAUDE.mdMakefiledocs/development/running-locally.md
Summary
Renames the
dev-teardowntarget todev-reset. This target is more analogous to theresettargets (dev-lima-reset,reset-fixture-lima,reset-fixture-ec2) than theteardowntargets, which also remove the VMs.I'm hoping this change will make me less likely to run the other
teardowntargets by accident.