Skip to content

chore: rename dev-teardown to dev-reset#341

Open
jason-lynch wants to merge 1 commit intomainfrom
chore/rename-dev-reset
Open

chore: rename dev-teardown to dev-reset#341
jason-lynch wants to merge 1 commit intomainfrom
chore/rename-dev-reset

Conversation

@jason-lynch
Copy link
Copy Markdown
Member

Summary

Renames the dev-teardown target to dev-reset. This target is more analogous to the reset targets (dev-lima-reset, reset-fixture-lima, reset-fixture-ec2) than the teardown targets, which also remove the VMs.

I'm hoping this change will make me less likely to run the other teardown targets by accident.

This target is more analogous to the `reset` targets (`dev-lima-reset`,
`reset-fixture-lima`, `reset-fixture-ec2`) than the `teardown` targets,
which also remove the VMs.
@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

📝 Walkthrough

Walkthrough

A make target was renamed from dev-teardown to dev-reset across the Makefile and related documentation files. The functionality remains unchanged, with only references and naming updated to reflect the new target name.

Changes

Cohort / File(s) Summary
Make Target Rename
Makefile
Renamed .PHONY declaration and target from dev-teardown to dev-reset, maintaining identical command behavior.
Documentation Updates
CLAUDE.md, docs/development/running-locally.md
Updated references from make dev-teardown to make dev-reset in development guidance and environment reset instructions.

Poem

🐰 Hopping through targets with glee,
From teardown to reset, we agree!
Dev environment squeaky and clean,
The finest rename we've seen! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description provides a clear summary and rationale but is missing the Changes section, Testing section, Checklist, and Notes for Reviewers as required by the template. Add a Changes section listing the affected files, a Testing section describing how to verify the rename, complete the Checklist, and add any Notes for Reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: rename dev-teardown to dev-reset' directly and clearly summarizes the main change—renaming a make target—matching the changeset perfectly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rename-dev-reset

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Makefile (1)

387-388: Consider a temporary compatibility alias for dev-teardown.

Non-blocking suggestion: keeping dev-teardown as a deprecated alias to dev-reset for one release cycle can prevent breaking local scripts while the new name rolls out.

Proposed transitional alias
 .PHONY: dev-reset
 dev-reset: dev-down
 	# remove postgres and supported services
 	ids=$$(docker service ls -q); \
 	if [ -n "$$ids" ]; then \
 		echo "$$ids" \
 			| xargs docker service inspect \
 			--format '{{.ID}} {{index .Spec.Labels "pgedge.component"}}' \
 			| awk '$$2=="postgres" || $$2=="service" {print $$1}' \
 			| xargs docker service rm; \
 	fi
 	docker network ls \
 		--filter=scope=swarm \
 		--format '{{ .Name }}' \
 		| awk '$$1 ~ /-database$$/' \
 		| xargs docker network rm
 	rm -rf ./docker/control-plane-dev/data
+
+.PHONY: dev-teardown
+dev-teardown:
+	`@echo` "WARNING: 'dev-teardown' is deprecated; use 'dev-reset' instead."
+	@$(MAKE) dev-reset
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Makefile` around lines 387 - 388, Add a temporary compatibility alias called
dev-teardown that depends on the new dev-reset target so existing scripts keep
working; implement it as a .PHONY target named dev-teardown which either lists
dev-reset as its prerequisite or invokes/makes dev-reset and optionally prints a
short deprecation warning, keep this alias for one release cycle and then remove
it when consumers have migrated.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Makefile`:
- Around line 387-388: Add a temporary compatibility alias called dev-teardown
that depends on the new dev-reset target so existing scripts keep working;
implement it as a .PHONY target named dev-teardown which either lists dev-reset
as its prerequisite or invokes/makes dev-reset and optionally prints a short
deprecation warning, keep this alias for one release cycle and then remove it
when consumers have migrated.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d1a8f8e1-86e2-4fdd-b687-21752c9316df

📥 Commits

Reviewing files that changed from the base of the PR and between b79ea7b and 7bb33d2.

📒 Files selected for processing (3)
  • CLAUDE.md
  • Makefile
  • docs/development/running-locally.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants