Skip to content

chore: quit circus in dev-lima-reset#342

Merged
jason-lynch merged 1 commit intomainfrom
chore/dev-lima-reset-quit-circus
Apr 13, 2026
Merged

chore: quit circus in dev-lima-reset#342
jason-lynch merged 1 commit intomainfrom
chore/dev-lima-reset-quit-circus

Conversation

@jason-lynch
Copy link
Copy Markdown
Member

Summary

Circus can keep running after your shell is disconnected, for example if your terminal program restarts. This commit updates the lima Makefile to ensure that circus and its control-plane processes are stopped in the teardown, reset, and run targets.

Testing

# in one terminal
make dev-lima-run

# in another terminal
make dev-lima-reset

# this should quit the running instance in your dev-lima-run terminal.

# there should not be any error if you re-run dev-lima-reset
make dev-lima-reset

Circus can keep running after your shell is disconnected, for example if
your terminal program restarts. This commit updates the lima Makefile to
ensure that circus and its control-plane processes are stopped in the
`teardown`, `reset`, and `run` targets.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Warning

Rate limit exceeded

@jason-lynch has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 27 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 56 minutes and 27 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 263fbab2-7363-4db1-acb2-d162d87907cf

📥 Commits

Reviewing files that changed from the base of the PR and between b79ea7b and 19b817a.

📒 Files selected for processing (2)
  • lima/.gitignore
  • lima/Makefile
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/dev-lima-reset-quit-circus

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@jason-lynch jason-lynch merged commit 1376a3b into main Apr 13, 2026
3 checks passed
@jason-lynch jason-lynch deleted the chore/dev-lima-reset-quit-circus branch April 13, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants