Skip to content

fix(replication): distribute destination omni among the subscribers#968

Open
meskill wants to merge 2 commits intopush-tmpxoryqppmpfrom
fix/replication-distribute
Open

fix(replication): distribute destination omni among the subscribers#968
meskill wants to merge 2 commits intopush-tmpxoryqppmpfrom
fix/replication-distribute

Conversation

@meskill
Copy link
Copy Markdown
Contributor

@meskill meskill commented May 7, 2026

Attempt to fix issue with test #924 by distributing the destination shards between streams, so they don't overlap and therefore can't deadlock each other. At the cost of consistency in case input omni tables are not equal in the content or the definition of the table changes from source to destination.

@meskill meskill force-pushed the push-tmpxoryqppmp branch from d395b91 to 2cc4e22 Compare May 10, 2026 21:13
@meskill meskill force-pushed the fix/replication-distribute branch from 2e9657c to c2a94ec Compare May 10, 2026 21:14
@blacksmith-sh

This comment has been minimized.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

❌ Patch coverage is 96.62162% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...nd/replication/logical/publisher/publisher_impl.rs 0.00% 3 Missing ⚠️
...d/replication/logical/subscriber/omni_ownership.rs 98.63% 1 Missing ⚠️
...c/backend/replication/logical/subscriber/stream.rs 87.50% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@meskill meskill marked this pull request as ready for review May 10, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant